supertuxkart-sourceforge-migration / stk-migration-test

0 stars 0 forks source link

Karts are displayed in wrong order in race gui / assigned to wrong team in soccer mode #811

Closed supertuxkart-sourceforge-migration closed 10 years ago

supertuxkart-sourceforge-migration commented 10 years ago

Author: deveee

It's regression since r12541.

When you play with three players, first player is displayed in left bottom edge. Previously it was top left.

It causes problems in soccer mode, where third player is detected as first and it is assigned to wrong team.

Even with two players, first player should be in red team and it's displayed as blue. But with two players it's not a big problem.

Perhaps it could be fixed in soccer mode files, but I don't see any easy solution for now.

supertuxkart-sourceforge-migration commented 10 years ago

Author: deveee Actually not a regression. r12541 changes order of displaying karts on split screen, but restore previous order doesn't fix the problem.

Problem is that when I use in setup screen (example for 4 players):

const RemoteKartInfo&   kart_info   = race_manager->getLocalKartInfo(i);
const std::string&      kart_name   = kart_info.getKartName();

I get: 0 suzanne 1 beagle 2 beastie 3 elephpant

But when I use in race:

World::getWorld()->getKart(i)->getIdent()

or World::getWorld()->getLocalPlayerKart(i)->getIdent()

I get wrong karts because they are in reversed order: 0 elephpant 1 beastie 2 beagle 3 suzanne

Is there any easy way to fix it, or should I in every place get real index using name of the kart? Currently I have no idea ;p

First order is this good - suzanne was as first player, beagle second etc.

supertuxkart-sourceforge-migration commented 10 years ago

Author: deveee Fixed in r14740. Thanks to hiker.