search

supertuxkart-sourceforge-migration / stk-migration-test2

0 stars 0 forks source link

Falling effect broken #102

Open supertuxkart-sourceforge-migration opened 10 years ago

supertuxkart-sourceforge-migration commented 10 years ago

Author: auria

In lighthouse when you throw yourself into water the camera is now following you

Migrated-From: https://sourceforge.net/apps/trac/supertuxkart/ticket/102

supertuxkart-sourceforge-migration commented 10 years ago

Author: auria Assigning to Joerg, because honestly, the code you added in r7773 just makes no sense ;) The code looks like

    if ( ... || (m_mode==CM_FALLING) )
    {
        // ...
    }
    switch(m_mode)
    {
    case CM_FALLING:
        // ...
    }

Of course the switch code is never called. Besides it seems to me like you just got rid of the code that would make the camera stay in place?

supertuxkart-sourceforge-migration commented 10 years ago

Author: auria Err I forgot the important statement in the code snippet above, sorry

    if ( ... || (m_mode==CM_FALLING) )
    {
        // ...
        return;
    }
    switch(m_mode)
    {
        case CM_FALLING:
            // ...
    }
supertuxkart-sourceforge-migration commented 10 years ago

Author: auria Sorry, yet another comment : the STK Browser features a "below-surface" property, I think this is no more needed?

supertuxkart-sourceforge-migration commented 10 years ago

Author: hikerstk Fixed in r7933.

Cheers, Joerg