Game slots vs deleting players

[supertuxkart-sourceforge-migration]

Author: auria

Deleting players would cause trouble to the new game slot system. 1) the unlock_manager relies on player IDs. deleting a player may change player IDs. 2) most especially, if you delete yourself, the game slot object will have a dangling pointer

Migrated-From: https://sourceforge.net/apps/trac/supertuxkart/ticket/519

[supertuxkart-sourceforge-migration]

Author: auria point 1 fixed as of r10378, we no longer rely on index

still todo : 2) most especially, if you delete yourself, the game slot object will have a dangling pointer

[supertuxkart-sourceforge-migration]

Author: auria Fixed in r10386.

TODO: 3) if a player renames themselves, problems may occur since the unlock manager uses player name as a unique id

[supertuxkart-sourceforge-migration]

Author: auria

TODO: 3) if a player renames themselves, problems may occur since the unlock manager uses player name as a unique id. and not only themselves, when a player is renamed the corresponding game slot must be renamed too to avoid losing their progress.

[supertuxkart-sourceforge-migration]

Author: auria Should be mostly fixed as of rr11146 - more testing required

[supertuxkart-sourceforge-migration]

Author: auria OK I think it all works

[supertuxkart-sourceforge-migration]

Author: auria In Wardje's case, the following IDs were generated :

!-- Represents one human player -->
    <Player
        name="Guest"
        guest="true"
        use_frequency="-1"
        unique_id="ffffffffa908650e"
        />

    <!-- Represents one human player -->
    <Player
        name="ward"
        guest="false"
        use_frequency="299"
        unique_id="4f96e52e163bbd2e"
        />

    <!-- Represents one human player -->
    <Player
        name="tina"
        guest="false"
        use_frequency="3"
        unique_id="ffffffffd624006c"
        />

Those 'ffffffff' are NOT right :(

[supertuxkart-sourceforge-migration]

Author: auria Fixed in r11151