search

supertuxkart-sourceforge-migration / stk-migration-test2

0 stars 0 forks source link

Loser stays as ghost when restarting 3 strikes #636

Open supertuxkart-sourceforge-migration opened 10 years ago

supertuxkart-sourceforge-migration commented 10 years ago

Author: auria

Initially reported on http://forum.freegamedev.net/viewtopic.php?f=17&t=3085&p=30334#p30334

After 3 strikes, if you restart, the loser remains hanging in the air and is not present to the physics

Migrated-From: https://sourceforge.net/apps/trac/supertuxkart/ticket/636

supertuxkart-sourceforge-migration commented 10 years ago

Author: auria The problem is that this line in Kart::eliminate is not properly undone on reset :

World::getWorld()->getPhysics()->removeKart(this);
supertuxkart-sourceforge-migration commented 10 years ago

Author: auria Tentative fix committed in r11247. Joerg, can you verify that my fix is appropriate? You know physics much better than I do

supertuxkart-sourceforge-migration commented 10 years ago

Author: hikerstk Looks correct (since I recently added code to avoid that a kart is added more than once ... I was about to raise this as an issue ;) ).

I am not closing this ticket since I want to have a look at why/when I broke it, just to make sure there isn't any other similar problem.

supertuxkart-sourceforge-migration commented 10 years ago

Author: auria This may have been me broking it, after I coded the new "ending" to 3 strikes where karts lose wheels