search

supertuxkart-sourceforge-migration / stk-migration-test2

0 stars 0 forks source link

Install issues on linux #837

Open supertuxkart-sourceforge-migration opened 10 years ago

supertuxkart-sourceforge-migration commented 10 years ago

Author: hikerstk

(11:02:21) DimStar: hiker: build seems clean so far.. only one 'file in the install' which is 'questionable': /usr/share/supertuxkart/data/po/gui_strings.h => should likely not be installed (11:02:51) DimStar: the other warning is: (11:02:51) DimStar: [ 353s] supertuxkart.x86_64: I: binary-or-shlib-calls-gethostbyname /usr/bin/supertuxkart (11:02:54) DimStar: [ 353s] The binary calls gethostbyname(). Please port the code to use getaddrinfo (11:03:31) DimStar: hiker: oh... and this file: /usr/share/supertuxkart/data/run_me.sh => it's installed with 644 and likely not to be used anyway...

Migrated-From: https://sourceforge.net/apps/trac/supertuxkart/ticket/837

supertuxkart-sourceforge-migration commented 10 years ago

Author: hikerstk This is the link given by dimstar containing the latest spec file used: https://build.opensuse.org/package/view_file?expand=1&file=supertuxkart.spec&package=supertuxkart&project=games

supertuxkart-sourceforge-migration commented 10 years ago

Author: auria gui_strings is indeed not needed, but at the same time it's harmless and quite small, so I think the work needed to exclude it from make dist and/or packaging is not worth the trouble.

supertuxkart-sourceforge-migration commented 10 years ago

Author: hikerstk AFAIK gui_strings is created when updating the pot file (from extract_strings) - and as such should not even be in STVN. Or am I missing something?

Other points reported by hasufell: (7:18:47 AM) hasufell: if you are pedantic you could provide a ${ICONDIR} variable, yeah... but well (7:19:15 AM) hiker: grin No need to be pedantic ;) (7:20:22 AM) hasufell: acutally that's the right way... provide seperate variables for: binary, data, doc, icons, manpage and config (7:20:31 AM) hasufell: and give sane defaults (7:20:40 AM) hasufell: but works for me, so. (7:20:53 AM) hiker: I'll wait for someone who can submit a patch then. (7:21:16 AM) hasufell: hiker: probably no one cares, cause those are very rare cases (7:21:25 AM) hasufell: maybe bsd will hit problems (7:21:30 AM) hasufell: not sure (7:22:29 AM) hasufell: you could just steal from http://svn.gna.org/svn/wesnoth/trunk/CMakeLists.txt (7:22:37 AM) hasufell: under "#Path options" (7:31:27 AM) hasufell: hiker: https://gist.github.com/4279529 something like that

supertuxkart-sourceforge-migration commented 10 years ago

Author: auria gui_strings.h removed from source control in r12978

supertuxkart-sourceforge-migration commented 10 years ago

Author: curaga The gethostbyname call is in enet, not our issue.

supertuxkart-sourceforge-migration commented 10 years ago

Author: magned Partially resolved; postponing rest till 0.8.2.