search

supertuxkart / stk-addons

SuperTuxKart Addons Website
Other
37 stars 28 forks source link

Calculate pagination without including hidden addons #160

Closed 3risian closed 1 year ago

3risian commented 1 year ago

Solves https://github.com/supertuxkart/stk-addons/issues/142

This counts the addons and filters them the same way the list does.

Addon::count is no longer used in the codebase, so it is deleted.

3risian commented 1 year ago

The current code filters pages after pagination, resulting in some pages having less than 10 items, so this fix should not be applied until the filtering is fixed.

3risian commented 1 year ago

This pull request now performs the filtering within the database query, fixing both the pagination miscount and the pages containing less than 10 items.