search

supertuxkart / stk-code

The code base of supertuxkart
Other
4.51k stars 1.06k forks source link

Splash effect shouldn't depend on having wheels #1156

Open supertuxkart-sourceforge-migration opened 10 years ago

supertuxkart-sourceforge-migration commented 10 years ago

Author: deveee

In one place there is some water on this track. There was splash effect and now there is only sound effect, without particle emitter.

Migrated-From: https://sourceforge.net/apps/trac/supertuxkart/ticket/1100

supertuxkart-sourceforge-migration commented 10 years ago

Author: deveee A bit stupid thing - I checked it using Xue kart, which doesn't have wheels. And in this case splash effect isn't displayed.

I leave this ticket open because sometimes this effect certainly should be displayed, it doesn't matter if you have wheels or not. For example when you fall to the river or to the sea in Lighthouse.

Alayan-stk-2 commented 6 years ago

Tested in Minigolf, still valid there.

Benau commented 4 years ago

Actually to fix this probably need a special particle type (for example KGFX_SPLASH) to handle just for water splash....

deveee commented 4 years ago

Check real bottom position of the kart in the same way as kart height for bubblegum shield? And see if it's on ground. Because both Gnu and Xue don't have wheels, but Gnu is flying, so it usually doesn't touch the water.