Wayland support - Githubissues

deveee commented 10 years ago

In near future (perhaps 1-2 years) main linux distributions (Ubuntu and Fedora) probably will use Wayland/Mir by default instead of X11. With Gnome 3.12 you can alredy run experimental Wayland session. Gnome 3.14 which will be released in autumn should have probably stable Wayland support. Even Nvidia works on support Wayland in their drivers.

I don't know if irrlicht developers have plans for support Wayland and Mir. I'm also not sure if we should wait for them or try to implement it. We have now a bit modified irrlicht version... Will we synchronise it with upstream irrlicht in future at all?

If currently a lot of work is done in pure OpenGL, maybe switch to SDL2 would be good idea? It already supports Wayland, Mir, Android and others. It seems to be better in handling window, keyboard input etc. than Irrlicht.

vlj commented 10 years ago

I'm not a display server expert but as far as I know opengl "just" needs an egl context to draw think to a wayland surface, so basically it's just a matter of changing a couple of replacing a couple of glxCreate... fonction with their egl counterpart in COpenglDriver.cpp (and potentially CIrrDeviceLinux.cpp) if we want to use irrlicht (everything on screen is drawn by opengl, there is no X toolkit involved) The big issue is not related to rendering anyway but with input, I suspect Irrlicht use direct X server hook to get keyboard event and forward it to stk, and wayland does change input handling quite a bit ; I'm not even sure the input binding api is finalized (trackpad acceleration is missing for instance in gnome wayland).

That's why I would be more in favor of sdl2, it handles all the egl/glx logic which would allow us not to care if the underlying server is Xorg, wayland, dwm or Quartz, and have a common subset of input events. The issue is that stk still requires irrlicht to load the model and I'm worried that an "independent" sdl2 and irrlicht may conflict with each other.

vlj commented 10 years ago

The big plus of SDL2 is that it's maintained and used by Valve, they use it for their source powered game.

deveee commented 10 years ago

Currently X11 is used for:

creating and managing window (minimize, maximize, move etc.)
reporting video modes and changing resolution (xrandr or vidmode)
mouse and keyboard events

As I see, you can already make irrlicht to use SDL by _IRR_COMPILE_WITH_SDLDEVICE flag. Maybe just modify it to use SDL2? Though in such case STK would depend on both - irrlicht and SDL...

Half-Shot commented 10 years ago

It's a fair point that I think SDL2 would be a great move to add next. It can abstract off the X11 stuff we are using which not only makes stk a little more compatible with other operating systems and fixes many issues I get with non-sdl games doing odd stuff with my display modes.

SDL2 is bundled with every distro I can name and I would believe that most have it installed anyway. Things like tabbing out of fullscreen windows is also a nice thing to have for the very little effort that SDL2 requires.

edit: and I might give a SDL2 port a try at some point, wasn't too hard to convert OGRE projects to SDL2.

deveee commented 9 years ago

I just would like to ask, which plans we have about irrlicht engine in future?

We probably won't upgrade whole irrlicht because there are too many modifications
A lot of code is already written in OpenGL. Will be irrlicht still really needed for us after 1-2 years?

I'm asking because I could do some experiments with wayland after 0.8.2 release. But I don't know if this would be useful at all (switch to SDL2 will make it certainly not useful).

@Half-Shot SDL2 is still missing in Debian stable ;) It already is in wheezy-backports, but even in backports sdl_image and sdl_mixer modules are still missing.

MatthewsSam commented 9 years ago

I'm not sure about Wayland.

However even now it's considered that we forked irrlicht.

After all the difficulties and the investment in this new engine we deserve that.

We can't say without laying that we are using irrlicht. The changes are very important and someone who download irrlicht today won't be able to get the same result without a significant amount of time and work.

It's also more clear for Linux packager.

As far as I know we aren't planning to update irrlicht. Instead we will make our own scene manager to replace definitively irrlicht.

I made an article on the wiki showing what the engine can do and also explaining that it is based on a heavily modified version of irrlicht.

It's also very clear that it's not a stand alone engine and it can be used in stk only. http://supertuxkart.sourceforge.net/Antartica_engine:_Overview

Btw off topic but deve are you the author of a soccer arena in the addons ?

Sam Le 12 déc. 2014 10:59, "Deve" notifications@github.com a écrit :

I just would like to ask, which plans we have about irrlicht engine in future?

We probably won't upgrade whole irrlicht because there are too many modifications

A lot of code is already written in OpenGL. Will be irrlicht still really needed for us after 1-2 years?

I'm asking because I could do some experiments with wayland after 0.8.2 release. But I don't know if this would be useful at all (switch to SDL2 will make it certainly not useful).

— Reply to this email directly or view it on GitHub https://github.com/supertuxkart/stk-code/issues/1390#issuecomment-66753002 .

deveee commented 9 years ago

When we will replace irrlicht, then we could use SDL2 for managing window and input events. And trying to support wayland in our own way would be useless.

Yes, I'm the author of soccer arena. I was trying to make something a bit more interesting for this rather boring game-type. But it's not finished. You can use it for something if you want ;)

Edit: *stklicht

vlj commented 9 years ago

We still rely on irrlicht to load our texture and mesh at the moment, and for our animations. We're still far from replacing irrlicht. However it could be possible to start to use SDL2 for OpenGL context/windows creation if you want to try. The relevant code is in IrrCOpenGLDriver.cpp and IrrDeviceLinux.cpp iirc (+ some objective c code for mac)

vlj commented 9 years ago

I opened a branch ("wayland") that adds an irrlicht driver for wayland. It works (mostly) well at the moment.

However I used Fedora 21 as a development/test platform (because gnome-shell as a wayland compositor is available out of the box as a gdm session, although not enabled by default) and thus it's likely harder to get it to build on others platforms.

However there is no window decoration at the moment, and it only supports base protocol (I don't know where to get the xdg-shell protocol include file used by gnome wayland client) so fullscreen/windows title/... is not supported for instance. And I'm not sure gamepad works (although it looks like the joystick support doesnt rely on X11 for linux device). Otherwise vsync, keyboard and pointer are supported.

Saroufim commented 9 years ago

I would like to chime in just to say that the game works quite well via XWayland. I've been testing it on openSUSE Tumbleweed with GNOME 3.15 on Wayland but the game fails to capture the full screen (it's stuck in windowed mode) and won't detect all the proper screen resolutions. As far as performance goes, on XWayland, the game didn't lose any FPS at all and I experience absolutely no lags. If you guys are in need of someone to help test things, I would be glad to step in. I have a steering wheel and a DualShock 3 controller as well as wired and wireless mice and keyboards. I'll get to testing the input immediately.

deveee commented 9 years ago

Did you check STK 0.8.1 or current git/beta version? They are using different methods to switch to fullscreen.

Vlj already made some work on support Wayland. I will probably look at this after upcoming STK release.

Saroufim commented 9 years ago

0.8.2 beta seems to be doing worse actually. It (naturally) doesn't start at all in a Wayland session and requires XWayland. When running under XWayland, attempting to change the resolution or switch to fullscreen mode crashes it. As for input, the DualShock 3 controller, the wireless and wired keyboards and mice, and the steering wheel are all properly detected and are as usable as they were on X11.

Wayland log:

/usr/games/supertuxkart [debug ] main: Error messages and other text output will be logged to /home/User/.config/supertuxkart/0.8.2/stdout.log. [info ] [FileManager]: Data files will be fetched from: '/usr/share/games/supertuxkart/data/' [info ] [FileManager]: User directory is '/home/User/.config/supertuxkart/0.8.2/'. [info ] [FileManager]: Addons files will be stored in '/home/User/.local/share/supertuxkart/addons/'. [info ] [FileManager]: Screenshots will be stored in '/home/User/.cache/supertuxkart/screenshots/'. [info ] [FileManager]: User-defined grand prix will be stored in '/home/User/.local/share/supertuxkart/grandprix/'. [info ] [FileManager]: Asset 0 will be loaded from '/usr/share/games/supertuxkart/data/challenges/'. [info ] [FileManager]: Asset 1 will be loaded from '/usr/share/games/supertuxkart/data/fonts/'. [info ] [FileManager]: Asset 2 will be loaded from '/usr/share/games/supertuxkart/data/gfx/'. [info ] [FileManager]: Asset 3 will be loaded from '/usr/share/games/supertuxkart/data/grandprix/'. [info ] [FileManager]: Asset 4 will be loaded from '/usr/share/games/supertuxkart/data/gui/'. [info ] [FileManager]: Asset 5 will be loaded from '/usr/share/games/supertuxkart/data/library/'. [info ] [FileManager]: Asset 6 will be loaded from '/usr/share/games/supertuxkart/data/models/'. [info ] [FileManager]: Asset 7 will be loaded from '/usr/share/games/supertuxkart/data/music/'. [info ] [FileManager]: Asset 8 will be loaded from '/usr/share/games/supertuxkart/data/tracks/'. [info ] [FileManager]: Asset 9 will be loaded from '/usr/share/games/supertuxkart/data/sfx/'. [info ] [FileManager]: Asset 10 will be loaded from '/usr/share/games/supertuxkart/data/shaders/'. [info ] [FileManager]: Asset 11 will be loaded from '/usr/share/games/supertuxkart/data/skins/'. [info ] [FileManager]: Asset 12 will be loaded from '/usr/share/games/supertuxkart/data/textures/'. [info ] [FileManager]: Asset 13 will be loaded from '/usr/share/games/supertuxkart/data/po/'. [debug ] translation: Env var LANGUAGE = 'en_US.utf8'. [debug ] translation: Language 'English (United States)'. tinygettext: jbo.po: warning: ignoring, unknown language tinygettext: sco.po: warning: ignoring, unknown language Adding language fallback en tinygettext: jbo.po: warning: ignoring, unknown language tinygettext: sco.po: warning: ignoring, unknown language Irrlicht Engine version 1.8.0 Linux 3.19.0-2-desktop #1 SMP PREEMPT Tue Feb 17 20:11:30 UTC 2015 (1133f88) x86_64 [warn ] irr_driver: The window size specified in user config is larger than your screen! [warn ] [IrrDriver Temp Logger]: Level 3: Error: Need running XServer to start Irrlicht Engine.