supertuxkart / stk-code

The code base of supertuxkart
Other
4.42k stars 1.04k forks source link

Remotely controlled movements of Nolok #1650

Closed GreenLunar closed 9 years ago

GreenLunar commented 9 years ago

On the racetrack which features two Noloks, when pressing before GO, non-human player Nolok moves accordingly.

Steps to reproduce this bug: Set Animated Characters to Human Players Only Select Story Mode Select Nolok kart Enter to the last challenge

deveee commented 9 years ago

Confirmed.

It occurs also when you continue saved Grand Prix and you have the same kart as AI

hiker commented 9 years ago

I can't reproduce: I have nolok as kart, settings to 'humans only', and if I steer left/right before ready, set, go - the AI nolok kart does not move. Does it depend on certain graphics options?

deveee commented 9 years ago

I checked it with the highest and the lowest settings and I cen reproduce it in both cases. I only need to set animations enabled (only for humans or for all karts).

Flakebi commented 9 years ago

It should happen each time, the same kart exists twice in a race because the animation modifies the mesh, so each kart gets updated (it happens while you're racing too, but it's harder to see). A solution would be to clone the mesh for each kart. I found this thread which covers a similar problem.

hiker commented 9 years ago

@Flakebi that should not be necessary. While the mesh is shared, the animation was re-computed every frame for each kart - but I have to check if that was changed with the new graphics.

hiker commented 9 years ago

While I can't reproduce it, most other people can. Apparently the new graphical pipeline does not support shared meshes anymore. I'll see about cloning the meshes.

hiker commented 9 years ago

Fixed in 9dd46b67557766041f044638331bef3a04fec972.

Thanks for the report! Joerg