Making the individual highscore data into a shared among all users

supertuxkart / stk-code

The code base of supertuxkart

Other

4.46k stars 1.05k forks source link

Making the individual highscore data into a shared among all users #2414

Open devnexen opened 8 years ago

devnexen commented 8 years ago

Related todo task High scores should be shared between different users on a machine, e.g. /var/games There are some problems with this approach (e.g. access to highscore files must be locked), so it's not as trivial as only changing the location of the highscore files.

Current status of the work

Only unixes systems are handled.
highscore file moved to /var/games/supertuxkart writable by everybody.
utfwriter class which is responsible of writing it underwent some changes for locking's sake.
mainly the C++ I/O stream converted to a plain C's one in order to use C locking function (fnctl for instance, can be changed to flock if prefered though).
once unix approach is validated, win32 oses would be handled (using _lock_file function maybe ? storing the highscore file inside Program Files\Supertuxkart ... ?)

nado commented 8 years ago

Isn’t there a microsoft thing like c:\users\all users ? Or better, scores handled by microsoft game explorer thingy ? I dont know how it works at all.

devnexen commented 8 years ago

I have no idea too yet, will see once I will set windows machine that might depends how the game itself is installed on windows.

devnexen commented 8 years ago

first draft

https://github.com/devnexen/stk-code/commit/4ff7897c382cfacd91804862477ea1b8a10efc73

Benau commented 8 years ago

Not sure if permission is required to be handled too (what account to use for writing highscore?)

BTW, why angelscript changes are needed?

devnexen commented 8 years ago

It should be writable by anyone. otherwise, the call frame information's part ... relating to certain versions of binutils you mut have .cfi_startproc/.cfi_endproc (OpenBSD for example) whereas with Linux versions it makes problems hence rather suppressing those instructions.

Benau commented 8 years ago

In fact, our bundled angelscript is old (not update to date version), not sure if it will be fixed too after an upgrade for next release.

devnexen commented 8 years ago

Ok I see, well not so important as we can use an already installed version ...

Benau commented 8 years ago

do you think it's a good idea to "split" angelscript changes out of your branch/submit as individual branch?

devnexen commented 8 years ago

no problem Benau yes I can bring back original version of the file.

https://github.com/devnexen/stk-code/commit/c004e3e9f021b4329d8f896cdd69b37d3c400172

Benau commented 8 years ago

seems that u mess up your master branch with unneeded files (see the dependencies 0.9.2 zip file) sorry if i was to blame for too much work for u......

consider squash some commits

devnexen commented 8 years ago

whoops good catch, should be better now ... can I create pull request or is it too early ?

Benau commented 8 years ago

Need our fellow lead devs to tell ya, who seem to be on holiday..

devnexen commented 8 years ago

no problems I understand :)

auriamg commented 8 years ago

A pull request is indeed the best way when you have changes that are ready to be reviewed/included