Crash in edit GP screen

[deveee]

  native: pc 00000000004035d2  /data/app/org.supertuxkart.stk-1/lib/arm/libmain.so (_ZN12EditGPScreen4initEv+485)
  native: pc 000000000049b089  /data/app/org.supertuxkart.stk-1/lib/arm/libmain.so (_ZN9GUIEngine20AbstractStateManager7popMenuEv+136)
  native: pc 00000000004ceec1  /data/app/org.supertuxkart.stk-1/lib/arm/libmain.so (_ZN12InputManager5inputERKN3irr6SEventE+1296)
  native: pc 000000000048a55b  /data/app/org.supertuxkart.stk-1/lib/arm/libmain.so (_ZN9GUIEngine12EventHandler7OnEventERKN3irr6SEventE+378)
  native: pc 0000000000602cbf  /data/app/org.supertuxkart.stk-1/lib/arm/libmain.so (_ZN3irr14CIrrDeviceStub17postEventFromUserERKNS_6SEventE+14)
  native: pc 00000000005ea125  /data/app/org.supertuxkart.stk-1/lib/arm/libmain.so (_ZN3irr17CIrrDeviceAndroid11handleInputEP11android_appP11AInputEvent+336)
  native: pc 00000000009f03e5  /data/app/org.supertuxkart.stk-1/lib/arm/libmain.so
  native: pc 00000000005e960b  /data/app/org.supertuxkart.stk-1/lib/arm/libmain.so (_ZN3irr17CIrrDeviceAndroid3runEv+102)
  native: pc 00000000003828b3  /data/app/org.supertuxkart.stk-1/lib/arm/libmain.so (_ZN9IrrDriver6updateEf+34)
  native: pc 000000000027b677  /data/app/org.supertuxkart.stk-1/lib/arm/libmain.so (_ZN8MainLoop3runEv+382)
  native: pc 0000000000242c43  /data/app/org.supertuxkart.stk-1/lib/arm/libmain.so (main+1642)
  native: pc 000000000027b8f7  /data/app/org.supertuxkart.stk-1/lib/arm/libmain.so (android_main+42)
  native: pc 00000000009f065b  /data/app/org.supertuxkart.stk-1/lib/arm/libmain.so
  native: pc 0000000000041747  /system/lib/libc.so (_ZL15__pthread_startPv+30)
  native: pc 0000000000019433  /system/lib/libc.so (__start_thread+6)

It's precisely states_screens/edit_gp_screen.cpp:176, which is:

            bool reverse = edit->getTrack()->reverseAvailable() ? 
                           edit->getReverse() : false;

Track is null in some cases?

[auriamg]

I'm unable to reproduce this particular issue, though I did find that if you add an add-on to a GP, then uninstall the GP, stk doesn't react well

[deveee]

I wasn't able to make a crash, but I somehow added two GPs with the same name :P

[Alayan-stk-2]

I did a few tests messing with the editor, and I was unable to reproduce any of the issues listed here (double-naming, crash, unexpected problems when uninstalling an addon track used in a GP (i.e., besides the GP being disabled)).

[deveee]

It's non-reproducible and didn't happen for a long time, so postpone till later.

[Benau]

after ~1 week no longer see "weird" crashes in google play console, so i assume those issue are fixed (I think multitouch -> update same category by the way)

maybe will these issues after master stk google play is updated

[kimden]

The crash seems to happen still as there's at least one report in public channels referring to the same lines of code in the same files. I also recall crashing once after using GP editor, but, unfortunately, it was too long ago. I couldn't reproduce the crash now, either, even by trying to make a GP with the same tracks as those causing the crash.

Line numbers have changed a bit so I'll post the call stack from 2024 from this post:

Call stack:

 edit_gp_screen.cpp:init:180
 abstract_state_manager.cpp:popMenu:258
 input_manager.cpp:input:1028
 event_handler.cpp:OnEvent:212
 CIrrDeviceStub.cpp:postEventFromUser:226
 CIrrDeviceSDL.cpp:run:1023
 main_loop.cpp:run:689
 main.cpp:main:2592
 crtexe.c:__tmainCRTStartup:341
 crtexe.c:WinMainCRTStartup:197
 BaseThreadInitThunk
 RtlUserThreadStart
---------------------------
OK
---------------------------