search

supertuxkart / stk-code

The code base of supertuxkart
Other
4.46k stars 1.05k forks source link

Icons look blurred on a 5K display #4066

Open risostk opened 4 years ago

risostk commented 4 years ago

Description

See the title and the following image: Screen Shot 2019-09-19 at 10 37 51 PM

Steps to reproduce

Configuration

STK release version: git 63b23d9

STK Source: github.com/supertuxkart/stk-code

System: macOS Mojave 10.14.6

Graphics card: Radeon Pro Vega 56 8GB

CPU: Intel Xeon W

Gamepads/keyboards models if related to the issue: NA

qwertychouskie commented 4 years ago

The icons are somewhat low-resolution. AFAIK some of these have SVG sources and could be exported to a higher res, though it might eat up more valuable space, though now that STK can download it's assets on launch on mobile, maybe it's not an issue. If @Benau gives the OK, I can make a PR with higher res icons. The one issue, however, is that high-res icons downscaled have jagged edges, I'm not sure if there's an easy way to fix this or not (different downsampling algorithm? dedicated HiDPI icon theme?)...

CodingJellyfish commented 4 years ago

Yes in 4k also a bit But u can try the stk 0.9.3 in 5k then you will find a little blur == nothing

risostk commented 4 years ago

@qwertychouskie Not sure if we can use SVG directly instead of PNG. Generally, SVG should have a smaller file size compared to PNG, and there is no downsampling problem. I guess the compatibility is the issue? Btw, Do you have the SVG/any type of source files of the tux icons of different difficulty levels? I only find the PNG file: https://svn.code.sf.net/p/supertuxkart/code/media/trunk/vector_art/tuxes_by_conso.png The SVG files in the folder are pretty out-of-dated. We also miss icons related to new modes like soccer, ffa, ctf, and egg. Maybe @Benau can help to find out the authors and to collect the source files?

@dumaosen Actually I think the issue is not very big. I could live with it, but it will be nicer to make stk better.

Benau commented 4 years ago

No svg in game is not possible because too much dependencies

Benau commented 4 years ago

svg added

Alayan-stk-2 commented 4 months ago

SVG support is good, but the icons currently used by the game for difficulty are still blurry.

@CodingJellyfish has done work on new improved .svg based icons so perhaps we can look at merging them (all or at least part of them to begin with) in master to properly solve this.

qwertychouskie commented 4 months ago

I have all the SVGs for the Cartoon skin, in addition to a number of reconstructed SVGs for the Classic skin. Just double-check to make sure that all the Cartoon SVGs match the PNGs that are currently committed, as it's very possible I accidentally pulled a few old versions.

Cartoon SVGs (Some may be outdated).zip Old icon style new icons.zip

A number of the Classic skin icons can be found in the Media repo as well.