search

supertuxkart / stk-code

The code base of supertuxkart
Other
4.53k stars 1.06k forks source link

Wrong GP highscore #4600

Open Alayan-stk-2 opened 3 years ago

Alayan-stk-2 commented 3 years ago

I have been testing the "grand prix highscore" feature.

After the first GP, I got the crash reported in #4599, which might have been caused by a malformed entry.

I noticed afterwards the GP was not registered as finished - it still had the option to continue from a saved point (which was just before the last race). This hints at a defect in properly registering a GP as finished going beyond any highscore feature. I think I've heard of a similar issue before, I'll have to check if I can find these old reports.

I took the option to continue from the saved GP. When the GP completed, I closed the game, reopened it and looked in the highscores and it was there. Except the displayed time is 12m29 when what was shown when completing the GP was 9m54s. I don't know how it happened, and if it is related to the GP resume, but this should not happen. If a resume invalidates a highscore, this should be spelled out and not lead to a saved entry with an unexplained time.

Issues to fix here:

@mrkubax10

mrkubax10 commented 3 years ago

Hmm, maybe this feature should be reverted. I will look at this through

Alayan-stk-2 commented 3 years ago

With all the work already done, reverting is not so great of an idea. The feature does have some value and the fix shouldn't be exceedingly hard.

Maybe use a small GP with 1 lap races and try to see if you can reproduce the issues I saw. Using the keyboard to quickly continue might be involved to trigger it.

mrkubax10 commented 3 years ago

I was unable to reproduce wrong time and malformed entries saved, maybe you can send your highscore.xml. I think reason for wrong time is that GP state was not saved correctly due to crash.

Benau commented 3 years ago

maybe it's fixed with https://github.com/supertuxkart/stk-code/commit/e74c19830110ee878b254186e87ddaa3f816fdb5, if it stills crash please post output of coredumpctl gdb supertuxkart (bt after typing)