search

supertuxkart / stk-code

The code base of supertuxkart
Other
4.54k stars 1.06k forks source link

Two settings that sounds the same: "Enable chatting online" and "Enable chatting in online games" #4623

Closed scootergrisen closed 3 years ago

scootergrisen commented 3 years ago

Description

"Enable chatting online" and "Enable chatting in online games" sounds a lot like the same. So i suggest making it more clear what the difference is if there is a difference or perhaps there only needs to be one of them.

Steps to reproduce

Launch STK Click Settings Look at "Enable chatting online" and "Enable chatting in online games"

Configuration

SuperTuxKart-1.3-rc1-installer-x86_64.exe 1.3-rc1 official binary

Benau commented 3 years ago

Second one means only disable chat in (playing) online games, and first one disable completely even in lobby

scootergrisen commented 3 years ago

Maybe the sub option should be idented so users can see it is a sub option of the parent.

Benau commented 3 years ago

Screenshot_20210923-234321_SuperTuxKart

scootergrisen commented 3 years ago

Graphics settings > Custom settings uses indentation for advanced pipeline. I would get rid of the "Enable". It's not good text for checkboxes because then you are saying "I enable Enable chatting online" and "I disable Enable chatting online". Let the checkbox state tell the user if the option is enabled or disabled. If there is two options lobby and during gameplay then maybe combine the options to a dropdown list or one of those horizontal lists used in graphics settings > Advanced pipeline > Shadows whatever they are called. Also when i disabled the parent option the checkbox of the child option is greyed out but the text of the child option stays the same so i suggest also greyout the text.

billede x x2

Maybe the Show always login screen should also be a sub option of Connect to the internet if it is only during with an internet connection.