search

supertuxkart / stk-code

The code base of supertuxkart
Other
4.52k stars 1.06k forks source link

Menu bugs when mouse hovered. #472

Open supertuxkart-sourceforge-migration opened 10 years ago

supertuxkart-sourceforge-migration commented 10 years ago

Author: vongan90

1.focus menu (using mouse) [menu (using mouse) http://www.youtube.com/watch?v=ptdkRyeO6Sk

Migrated-From: https://sourceforge.net/apps/trac/supertuxkart/ticket/416

supertuxkart-sourceforge-migration commented 10 years ago

Author: auria This is a known limitation of ribbon widgets, but as you have noted, it's rather minor. Pushing it back since it's not necessary to have it done for 0.7.3

supertuxkart-sourceforge-migration commented 10 years ago

Author: auria No release blocker and no time to work on that, so pushing it back again

qwertychouskie commented 8 years ago

Can probably be closed, since main menu doesn't have this layout anymore.

auriamg commented 8 years ago

@qwertychouskie : irrelevant, other menus still have similar issues.

qwertychouskie commented 8 years ago

Although the issue still exists (tested in latest git), is it really a problem? When using a mouse, you are going to hover directly over what you want to click anyways, and keyboards and gamepads are not affected. My opinion is to close it, or at least set it as P5: trivial.

Alayan-stk-2 commented 6 years ago

I had to purposefully try to reproduce it to do so. I'm frankly not convinced at all that it's an issue that the selection follows the mouse vertically (if you keep it inside the zone with the ribbons ; at first I tried by moving the mouse outside it and it does nothing).

If anything, making it also follows the mouse horizontally would seem like a better way to close this issue.

qwertychouskie commented 6 years ago

This actually bit me once in the network lobby, because the ribbon that holds the Exit button is much bigger than the button itself (when hosting the server this ribbon also has a Start Race button).

qwertychouskie commented 6 years ago

@Alayan-stk-2 This should be easy enough to fix now with the new navigation code.

Alayan-stk-2 commented 6 years ago

The way the ribbons work has not fundamentally changed. The main navigation will let the ribbon choose to handle himself the input (which he does like before) or to ask for the main navigation to handle it. (However, the networking lobby is not an issue anymore as the parent ribbon has been removed)

Still, I understand a bit better the GUI code now, so I'll have a look, there may be a simple solution.

Alayan-stk-2 commented 6 years ago

This is the crux of the issue : /** DynamicRibbonWidget is made of several ribbons; each of them thus has its own selection independently of each other.

So, when moving up and down, the game registers a change in the selected parent ribbon, and change the focused child element.