supertuxkart / stk-code

The code base of supertuxkart
Other
4.39k stars 1.03k forks source link

Fix #4984 & #4995 #4998

Closed CodingJellyfish closed 5 months ago

CodingJellyfish commented 5 months ago

Changing normal encoding into https://knarkowicz.wordpress.com/2014/04/16/octahedron-normal-vector-encoding/

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.
Benau commented 5 months ago

how you fixed the 'kart selection darker' issue as mentioned in irc channel?

CodingJellyfish commented 5 months ago

how you fixed the 'kart selection darker' issue as mentioned in irc channel?

That's possibly because he has changed other shaders (Specular BRDF). It's not reproducible for me.