search

supertuxkart / stk-code

The code base of supertuxkart
Other
4.36k stars 1.03k forks source link

add support for system Bullet #5048

Closed ognevny closed 1 month ago

ognevny commented 1 month ago

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.
qwertychouskie commented 1 month ago

Using system Bullet is not an option, see https://github.com/supertuxkart/stk-code/issues/5035#issuecomment-2005581607

eli-schwartz commented 1 month ago

This pull request doesn't contain any version matching to ensure that the correct version of bullet is used. In theory the objections from the linked ticket could could be answered via requiring specific versions or else mandating the bundled copy

While I would absolutely appreciate support for a system copy too, I think it's extremely important to collaborate with upstream's concerns that "just any version" will produce incorrect results.

qwertychouskie commented 1 month ago

This pull request doesn't contain any version matching to ensure that the correct version of bullet is used. In theory the objections from the linked ticket could could be answered via requiring specific versions or else mandating the bundled copy

While I would absolutely appreciate support for a system copy too, I think it's extremely important to collaborate with upstream's concerns that "just any version" will produce incorrect results.

Even "the exact same version" wouldn't work, as STK's Bullet has had modifications made over the years, including changes to functionality.

https://github.com/supertuxkart/stk-code/commits/master/lib/bullet