supertuxkart / stk-code

The code base of supertuxkart
Other
4.41k stars 1.04k forks source link

The inside of selection halos make the UI worse in splitscreen kart selection #5127

Open Alayan-stk-2 opened 2 weeks ago

Alayan-stk-2 commented 2 weeks ago

If two or more players try to select the same kart in the splitscreen kart selection, their colored control indicator are overlaid with one being set bigger than the other.

This used to work well, but I have noticed in recent testing that now the semi-transparent blurry part from the exterior colors is drawn on top of the interior indicator, making them much less visible.

I am not sure what change broke things in this regard or when it happened, but the issue is reproducible on 1.4 too.

WrongOverlap

Expected behavior : the semi-transparent part from the bigger indicators is not drawn so the color and presence of the smaller indicators remain clearly visible.

Alayan-stk-2 commented 2 weeks ago

The easiest fix may be to simply draw these indicators in reversed order, so that the interior ones are drawn on top of the semi-transparent halo instead of below it. I suspect this is how it used to be done when this worked properly, as the skins were not updated in this regard.