search

supertuxkart / stk-code

The code base of supertuxkart
Other
4.54k stars 1.06k forks source link

Referees not removed #974

Closed supertuxkart-sourceforge-migration closed 10 years ago

supertuxkart-sourceforge-migration commented 10 years ago

Author: hikerstk

If you restart a race while a referee is shown, the old one is still shown, so you end up with more than one referee.

supertuxkart-sourceforge-migration commented 10 years ago

Author: navaneeth-bhat Value of start-offset in data/models/referee.xml changed to -1,1,1 for for better positioning of the referee in shifting sands.

supertuxkart-sourceforge-migration commented 10 years ago

Author: auria The parts about double-referee have been committed in r12651. Thanks!

supertuxkart-sourceforge-migration commented 10 years ago

Author: nixt Will it not cause problems in other tracks by changing the positioning in referee.xml?

supertuxkart-sourceforge-migration commented 10 years ago

Author: hikerstk I agree, it's odd that only one track has an invalid start position (and not all). Iirc the position should just be relative to either the kart or camera (and kart-camera position should be identical at start). Also, the ticket should only be closed (i.e. set to fixed) when the patch has been applied, so I reopen this ticket.

supertuxkart-sourceforge-migration commented 10 years ago

Author: navaneeth-bhat There is a separate ticket regarding the referee invalid start position position in http://sourceforge.net/apps/trac/supertuxkart/ticket/917. The main defect of this bug i.e multiple referee patch has been applied.

supertuxkart-sourceforge-migration commented 10 years ago

Author: hikerstk Properly fixed in r12664: reason for the multiple referees (and a memory leak) was that the init function of the RaceGUI was called twice, but it should only be called once after the constructor. The patch worked since it avoided recreating the referee the 2nd time init() was called. And yes, referee position issues should go to #917.