supertuxkart / stk-editor

SuperTuxKart - Track Editor
GNU General Public License v3.0
55 stars 24 forks source link

Fix a couple of memory and resource leaks. #4

Closed CruzR closed 9 years ago

CruzR commented 9 years ago
hiker commented 9 years ago

@leyyin since you are so good with coding style - do you want to have a look? Thanks!

vampy commented 9 years ago

Also, where does the style guide forbid the usage of C++11? EDIT: found the sentence, needs to be changed and going to have a discussion with @hiker about changing it.

konstin commented 9 years ago

afaik It was decided to use C++11 though it was never advertised because of problems with Mac OS X and older compilers.

auriamg commented 9 years ago

This was true until recently, though we have now moved to C++ 11 - the only restriction is that features should work in GCC 4.8 and VS 2013 (so no features that were implemented after that). I think unique_ptr was implemented relatively early on all compilers so it should be fine, though

CruzR commented 9 years ago

Alright, I've updated this commit to use std::unique_ptr instead.

vampy commented 9 years ago

Looks good, thanks!