Closed CruzR closed 9 years ago
@leyyin since you are so good with coding style - do you want to have a look? Thanks!
Also, where does the style guide forbid the usage of C++11? EDIT: found the sentence, needs to be changed and going to have a discussion with @hiker about changing it.
afaik It was decided to use C++11 though it was never advertised because of problems with Mac OS X and older compilers.
This was true until recently, though we have now moved to C++ 11 - the only restriction is that features should work in GCC 4.8 and VS 2013 (so no features that were implemented after that). I think unique_ptr was implemented relatively early on all compilers so it should be fine, though
Alright, I've updated this commit to use std::unique_ptr
instead.
Looks good, thanks!