supervons / react-native-echarts-pro

A React-Native charts based on Apache ECharts, support various charts and map.
https://supervons.github.io/react-native-echarts-pro-docs/
MIT License
216 stars 33 forks source link

[fix] Adapt to android's "display size" #47

Closed RengeRenge closed 2 years ago

RengeRenge commented 2 years ago

the size of web view is different from html element's size

https://github.com/supervons/react-native-echarts-pro/issues/45

Test plan

On Android platform,go to SettingsDisplayDisplay Scaling/Display Size, adjust the scale

without this PR, the size of html element will be different from the size of the web view, echarts will not fill up.

supervons commented 2 years ago

Thanks for your PR.

Associated problems https://github.com/supervons/react-native-echarts-pro/issues/45 ?

Please provide a test case.

RengeRenge commented 2 years ago

Thanks for your PR.

Associated problems #45 ?

Please provide a test case.

Yes, this PR fixed https://github.com/supervons/react-native-echarts-pro/issues/45

supervons commented 2 years ago

Can you provide test plan?

RengeRenge commented 2 years ago

Can you provide test plan?

I have added test plan.