[BUG] PaywallOverrides doesn't work in Superwall.track - Githubissues

superwall / Superwall-iOS

Remotely configure every aspect of your paywall and double your revenue.

https://superwall.com

MIT License

89 stars 24 forks source link

[BUG] PaywallOverrides doesn't work in Superwall.track #102

Closed quanganhdo closed 1 year ago

quanganhdo commented 1 year ago

New issue checklist

[x] I have reviewed the README and documentation
[x] I have searched existing issues and this is not a duplicate
[ ] I have attempted to reproduce the issue and include an example project.

General information

Superwall version: 3.0.0-beta.1
iOS version(s):
CocoaPods/Carthage version (if applicable):
Xcode version:
Devices/Simulators affected:
Reproducible in the demo project? (Yes/No):
Related issues:

Describe the bug

https://github.com/superwall-me/SuperwallKit-iOS/blob/master/Sources/SuperwallKit/Dependencies/DependencyContainer.swift#L217-L244

paywallOverrides isn't used in the function body.

Steps to reproduce

Please also include a description of expected vs. actual behaviour

Other Information

e.g. stacktraces, suggestions how to fix, links for us to have context, eg. stackoverflow, etc.

yusuftor commented 1 year ago

Great catch, thank you!!