Closed gierschv closed 1 year ago
This is a real bug! Thanks for the detailed report and pull request. I've changed this to merge to our develop branch before we release to master with other upcoming fixes. We actually have some UITests (not included in this project), but we don't have a UITest that identifies with the same userId, so we'll add that in.
Changes in this pull request
When calling
Superwall.shared.identify(userId: "abc")
when opening app instead of only during login, IdentityManager.didSetIdentity is never execute since the queue is stuck. Bug repro: set identity in AppDelegate and open app twice (works first time, fails afterwards).This bug also blocks future calls to
Superwall.shared.getPresentationResult
that never returns sinceidentityManager.hasIdentity
is always false in AwaitIdentifyOperator, and never opens future paywalls.Checklist
identify()
.CHANGELOG.md
for any breaking changes, enhancements, or bug fixes.swiftlint
in the main directory and fixed any issues.