superwf / vuex-cache

cache vuex action when dispatch
MIT License
510 stars 32 forks source link

Remove peerDependencies #2

Closed VitorLuizC closed 7 years ago

VitorLuizC commented 7 years ago

I'm using Vuex 3 for a while with vuex-cache and today I realize vuex-cache is warning about incorrect peer depedency.

warning " > vuex-cache@1.0.0" has incorrect peer dependency "vuex@^2.2.1".

Adding 3.x to peerDependencies would solve it, because 3.0 doesn't break plugins and dispatch APIs, but looking at Vuex 1 docs you can also notice plugins and dispatch APIs are same too. So, vuex-cache is compatible with all vuex versions and there's no reason to keep a peerDependencies checking it.

I'm just ignoring Vuex 0.x...

VitorLuizC commented 7 years ago

I forgot about checking Vue version and since vuex-cache handle just Vuex we can remove it too.

VitorLuizC commented 6 years ago

@superwf This is still warning. Can you publish changes to npm?

superwf commented 6 years ago

published~