search

superzanti / ServerSync

Sync files between client and server for Minecraft Forge
GNU General Public License v3.0
163 stars 26 forks source link

[1.15.2]exe program, no Chinese translation #175

Closed EnterFor closed 4 years ago

EnterFor commented 4 years ago

Serversync Version:

3.4.0

Minecraft Version:

1.15.2

Issue:

no Chinese translation.. Must I switch to the jar version? I think the exe version of the icon looks better..

rheimus commented 4 years ago

The exe version is basically just a zip file with the java files inside it, it should be identical.

You can even open the file with 7zip (or other zip programs) and have a poke around in the files if you like 👍, translations end up in the assets folder.

There is probably some kind of issue with the build when it copies the files into the package.

EnterFor commented 4 years ago

image Yes, I found it, but it doesn't show Chinese when I run it. Does this have anything to do with me changing the exe program file name?Or is it a BUG?

rheimus commented 4 years ago

Changing the name of the file should be fine.

Does it have some translation or none at all? There are several strings that have not been hooked into the resource bundle yet.

EnterFor commented 4 years ago

None at all. It only shows English image image The Chinese shown in the figure is that I annotated the Mod so that I could better view it

image

rheimus commented 4 years ago

Could you send me the client logs please.

I get the feeling that the client is failing to match your locale string to the resource bundle.

EnterFor commented 4 years ago

serversync-client.log Is this it?

Addendum: I asked several server players, and when they updated, they also showed English

rheimus commented 4 years ago

Apologies, github decided to auto close this.

Though the latest merge should indeed fix the issue, looks like ServerSync was never loading resource bundles properly.

rheimus commented 4 years ago

Early test files can be found here: https://github.com/superzanti/ServerSync/actions/runs/72526484

EnterFor commented 4 years ago

image Ummmmm....Seems to be worse.

rheimus commented 4 years ago

😢 Bummer, probably need to play with the encoding.

EnterFor commented 4 years ago

If there is no way, it doesn't matter~~~~Not affecting use，Thank you for your hard work

rheimus commented 4 years ago

The issue is that by default in java 7 & 8 resource bundles are encoded in ISO.

I should be able to work around this and get the bundle as utf-8.

rheimus commented 4 years ago

Give this one a try https://github.com/superzanti/ServerSync/actions/runs/72674632

I have just converted the file to use unicode escapes for now, shall work on a better solution later.

EnterFor commented 4 years ago

image Nice!!!!!!!!!!!!!!!!!!!!!

rheimus commented 4 years ago

👍, just need to actually hook up the various strings in the app to the resource bundles now.

EnterFor commented 4 years ago

Wait a minute, I found multiple extra strings, I think I can supplement the translation. https://github.com/superzanti/ServerSync/pull/182

EnterFor commented 4 years ago

Sorry, I found a flaw in the translation. It has been resubmitted.

If there are no other questions, this question can be closed. Thanks again for your patience. I seem to be a bit wordy..xD.