superzanti / ServerSync

Sync files between client and server for Minecraft Forge
GNU General Public License v3.0
163 stars 26 forks source link

Serversync not ignoring files #192

Closed Alkiasan closed 4 years ago

Alkiasan commented 4 years ago

Serversync Version:

3.5.1

Minecraft Version:

1.14.4

Issue:

Added Optifine.jar to my mods folder as a test, and disabled it from being synced inside of the server's config file, but for some reason, Serversync consistently deletes it.

image Above image states that there are no ignored files. image Above image is Serversync's logs deleting the file. image Above image is the serverside config. Trying both / and \ just in case i'm being dumb.

HaibaraGT commented 4 years ago

Serversync Version:

3.5.1

Minecraft Version:

1.14.4

Issue:

Added Optifine.jar to my mods folder as a test, and disabled it from being synced inside of the server's config file, but for some reason, Serversync consistently deletes it.

image Above image states that there are no ignored files. image Above image is Serversync's logs deleting the file. image Above image is the serverside config. Trying both / and \ just in case i'm being dumb.

You may need to put mods like optifine in the clientmods folder to avoid serversync deleting it. Create a folder of folderclimods in the root directory of the server and put optifine.jar in it. Adjust the serversync configuration file

servser      B: PUSH_CLIENT_MODS = true clinet     B: REFUSE_CLIENT_MODS = false

rheimus commented 4 years ago

Optifine is indeed one of the mods I had in mind when designing the clientmods feature. https://github.com/superzanti/ServerSync/wiki/Client-Mods

Though it would seem that there might be a misunderstanding of the ignore list functionality here?

The ignore list for a server will define a list of files that exist on the server but will not be sent to the client (i.e. they are ignored by the server). This was designed for servers to run 'server side only' mods that are not required to exist in the clients mod list.

The ignore list for a client will define a list of files that exist on the client but will be ignored during the deletion phase (i.e. the client knows this file will not interfere with connecting to the server). This functionality was designed for clients to use their own favorite client side mods without the server needing to know about it.

Alkiasan commented 4 years ago

Ah, okay, yeah, I got the ignore list functionality wrong then. Was hoping it was possible to stop the server from detecting certain mods without editing clientside, but in the end ended up just giving people modified clientside configs haha. Thanks for the response ^^