search

superzanti / ServerSync

Sync files between client and server for Minecraft Forge
GNU General Public License v3.0
160 stars 26 forks source link

Add retries on file sync failure #290

Open NanobotZ opened 2 years ago

NanobotZ commented 2 years ago

Serversync Version:

4.2.0

Minecraft Version:

doesn't matter

Issue:

According to this line, it doesn't matter whether file updates are run successfully or not, the program doesn't inform the user that something went wrong while processing nor it doesn't try to retry the update action again later, as the boolean value returned by this function isn't handled anywhere. https://github.com/superzanti/ServerSync/blob/c2d9371054bf23fffa6a30eb2f69225635546ae2/src/main/java/com/superzanti/serversync/client/Mode2Sync.java#L38

I don't think this is a good behavior, as client users with spotty internet connection (I know two that run into this problem) may not even notice that something went wrong while syncing with the server, especially if running in no-GUI mode.

rheimus commented 2 years ago

Yep, retries ended up being removed at some point. Makes sense to add them back in with some sort of exit handling/ui for it as well.