search

support-project / knowledge

Free Knowledge Management System
Apache License 2.0
717 stars 187 forks source link

slideshow doesn't working #1069

Open kikd opened 5 years ago

kikd commented 5 years ago

Description Slideshow feature doesn't working on Chrome and Firefox.

Version v1.13.1

Environment

To reproduce

  1. access to Slide show sample
  2. press the slide show button.

Expected behavior Browser toggle full screen mode, and begin slide show.

Actual behavior [Chrome] Browser cannot toggle to full screen mode with some error. Developer console displays error message below.

4?offset=0:1 Uncaught (in promise) TypeError: Failed to execute 'requestFullscreen' on 'Element': parameter 1 ('options') is not an object.
    at HTMLAnchorElement.onclick (4?offset=0:1)
onclick @ 4?offset=0:1

[Firefox] Browser toggle to full screen mode, but slideshow isn't start as below. fullscreen

Remarks Presentation occurs same issue.

nus commented 5 years ago

I create a pull request for fixing this issue.