search

supranational / blst

Multilingual BLS12-381 signature library
Apache License 2.0
458 stars 175 forks source link

node: Added c++20 compiler for node19 #149

Closed maschad closed 1 year ago

maschad commented 1 year ago

Following the conversation https://github.com/swig/swig/issues/2506 I had initially thought this was a SWIG code generation but it just turns out the bash script was not utilizing the correct toolchain in order to support Node 19

dot-asm commented 1 year ago

This is too "radical" :-) On a more serious note I mean that for example the default Ubuntu 20 compiler doesn't support -std=c++20, while it's not actually required to compile, c++17 appears to be sufficient. One can also make a case for being more conservative and fixing specifically what is broken... In other words I've settled for d334254a4125cd2676d40b11229df208db8902e0. Thanks for the prompt!

maschad commented 1 year ago

Good fix! Thanks!