supsm / MCPPPP

A resource pack converter from Optifine/MCPatcher formats to other formats
Mozilla Public License 2.0
123 stars 7 forks source link

Textures based on named mobs don't transfer over #2

Closed Garfieldwxg55 closed 3 years ago

Garfieldwxg55 commented 3 years ago

In Optifine, mobs can be given custom textures based on what they are named, and this is able to be replicated in Varied Mob Textures with the name selector. However, this is not converted over when you convert the resource pack with the converter.

supsm commented 3 years ago

This is actually intentional. Using the name selector will cause the game to crash. I've opened a pull request on vmt a while ago, but it's been suspended so I'm not sure when it'll get merged (hopefully summer)

Garfieldwxg55 commented 3 years ago

Oh thanks, hopefully if it gets merged I'll be able to port my resource pack over then!

supsm commented 3 years ago

The changes actually are already there, just commented out. If you want, tell me your os and I'll build it for you

Garfieldwxg55 commented 3 years ago

Oh I use Windows 10 Home

supsm commented 3 years ago

Try this, tell me if anything breaks. If you want to send your resource pack to someone else, they'll have to use my modified mod vmt.zip (I have to zip it because github won't let me upload .exe or .jar)

supsm commented 3 years ago

This will be fixed in 1.17 update of vmt (soon :)

Garfieldwxg55 commented 3 years ago

Hi, I just recently tried using the conversion tool, and it seems to have not converted the resource pack properly. The log shows that there are no files in the assets file, and skipped over the optifine folder (which is where all my custom textures are located). Is this a known issue? Many thanks

supsm commented 3 years ago

I'll look into it tomorrow

Garfieldwxg55 commented 3 years ago

Thanks :)

supsm commented 3 years ago

Would you mind uploading the resource pack?

supsm commented 3 years ago

Nevermind, I think I spotted the issue