search

sur950 / any_link_preview

A flutter Plugin/Package to show the preview of any web link that starts with HTTP/HTTPS. Mostly useful for application that had chat.
MIT License
70 stars 71 forks source link

Migrate to null-safety #10

Closed ghpranav closed 3 years ago

ghpranav commented 3 years ago

Should fix #9

ghpranav commented 3 years ago

@sur950 sorry for the force pushes. Now the changes have been completely tested with the given example code & everything seems to be working without any breaking changes.

sur950 commented 3 years ago

Thanks for the PR @ghpranav , I will verify & will merge it tomorrow

sur950 commented 3 years ago

@ghpranav I think you have used charset_converter package for Encode and decode of charsets. But this is only supported for Android & IOS, Our aim should be focusing for most of the platforms.

If you have time, Could you help me in finding any other alternative plugin/package for charset_converter

Thanks!

ghpranav commented 3 years ago

I did try searching for other alternatives, but none of them seemed to be migrated to null-safety yet. I will let you know if I find one

ghpranav commented 3 years ago

@sur950 please check now. Also, if you can somehow remove the dependency on dart:isolate then your package can support Web as well.