Closed Satsrag closed 1 year ago
That's great! I wish I had had your solution before! In the current version of the mongol
package I've completely removed MongolRenderEditable
and the other related classes from the library. My hope has been to reimplement them based on the super_editor package, but I haven't had time. However, if you've found a solution to the previous error, it may be faster to use your solution first. What do you think about adding your solution on a new branch? Then we can test it. If everything is working we can merge it into the main branch.
I try to go back to the previous version of the mongol
package to check out the new branch and then add the solution. But when I merge it to the master branch, some MongolTextFiled
related code was deleted again.
So I think checkout the new branch from the current version of the mongol
package and then copy the MongolTextFiled
related code from the previous version. Then add the solution and others?
Yes, let's not merge into the master branch for now. Let's create a new branch. Then people can use that branch if they need your fixed MongolTextField
. Should I create a new branch?
Yes .
I created a new branch from master named editor-fixes
. Feel free to modify this branch however you like.
I pull request
to the editor-fixes
branch #23. Please search todo editor-fixes
to check my modified part.
I think the editor-fixes
branch is almost ready to merge into master
. It's really nice to see the editor widget working again.
I've pushed a few minor cleanup changes to that branch. Before we merge, though, we should evaluate these issues:
@Satsrag I've merged your changes into the master branch. Everything seems to be working well enough. I need to update the documentation and then I'll publish the update to Pub as Version 3.1.0. If you know of any issues that should be fixed first, please open another issue.
I've published your fixes in version 3.1. In addition to fixing the scrolling issue, it's also great to have the arrow keys working on web and desktop. Thank you very much!
The issue occurred in
paint(PaintingContext context, Offset offset)
method ofMongolRenderEditable
class . The has issue code:The solution code:
The
_clipRectLayer
has been disposed when callcontext.pushClipRect
method. So useLayerHandle
to prevent_clipRectLayer
from disposing. The solution code copy from flutter sourceRenderEditable
.