suragch / mongol

Mongolian vertical script widgets for Flutter apps
https://pub.dev/packages/mongol
BSD 3-Clause "New" or "Revised" License
70 stars 15 forks source link

Remove DefaultMongolTextEditingShortcuts from MongolEditableTextState #35

Closed Satsrag closed 1 year ago

Satsrag commented 1 year ago

This is the second solution that is mentioned in #33. The last solution is not working. Such as, in TextField, left/right+alt and up/down+meta will invoke ExtendSelectionToLineBreakIntent and up/down+alt will invoke ExtendSelectionToNextWordBoundaryIntent. In MongolTextField we will switch ExtendSelectionToLineBreakIntent and ExtendSelectionToNextWordBoundaryIntent to switch left/right+alt and up/down+alt. However, ExtendSelectionToLineBreakIntent also means pressing up/down+meta. This is a conflict and solving it is complex.

suragch commented 1 year ago

Can we change the name from DefaultMongolTextEditingShortcuts to MongolTextEditingShortcuts? The reason is that it's not really the default. It's a required variation from the default that the developer must specify. The actual default is still DefaultTextEditingShortcuts.

This requested change affects the class name and file name.

Satsrag commented 1 year ago

You are right, I have renamed it.