suragch / mongol

Mongolian vertical script widgets for Flutter apps
https://pub.dev/packages/mongol
BSD 3-Clause "New" or "Revised" License
70 stars 15 forks source link

error with (MongolEditableTextState) #5

Closed Zolbayar8027 closed 3 years ago

Zolbayar8027 commented 3 years ago

/C:/src/flutter/.pub-cache/hosted/pub.dartlang.org/mongol-1.1.0/lib/src/editing/mongol_editable_text.dart:1013:7: Error: The non-abstract class 'MongolEditableTextState' is missing implementations for these members:

class MongolEditableTextState extends State ^^^^^^^^^^^^^^^^^^^^^^^ /C:/src/flutter/packages/flutter/lib/src/services/text_input.dart:822:8: Context: 'TextSelectionDelegate.userUpdateTextEditingValue' is defined here. void userUpdateTextEditingValue(TextEditingValue value, SelectionChangedCause cause); ^^^^^^^^^^^^^^^^^^^^^^^^^^ /C:/src/flutter/.pub-cache/hosted/pub.dartlang.org/mongol-1.1.0/lib/src/editing/mongol_editable_text.dart:1983:8: Error: The method 'MongolEditableTextState.hideToolbar' has fewer positional arguments than those of overridden method 'TextSelectionDelegate.hideToolbar'. void hideToolbar() { ^ /C:/src/flutter/packages/flutter/lib/src/services/text_input.dart:829:8: Context: This is the overridden method ('hideToolbar'). void hideToolbar([bool hideHandles = true]); ^ /C:/src/flutter/.pub-cache/hosted/pub.dartlang.org/mongol-1.1.0/lib/src/editing/mongol_editable_text.dart:2156:43: Error: Required named parameter 'context' must be provided. return widget.controller.buildTextSpan( ^

suragch commented 3 years ago

It looks like this is an issue with a release of Flutter on the master channel. I'll probably need to update the package if this change makes it to the stable channel.

suragch commented 3 years ago

This bug exists on the stable channel with Flutter 2.2 now. I'm working on fixing it.

suragch commented 3 years ago

@ipcjs @Zolbayar8027 Version 2.0.0 of this package fixes this bug and basic functionality should all work again. There are a few bugs with MongolTextField, though, so please open another issue if they affect your app and I'll try to prioritize those bugs first.