search

suragch / mongol

Mongolian vertical script widgets for Flutter apps
https://pub.dev/packages/mongol
BSD 3-Clause "New" or "Revised" License
70 stars 15 forks source link

Material3 #51

Closed Satsrag closed 3 months ago

Satsrag commented 4 months ago

for #50

Adopt to material3.

Satsrag commented 4 months ago

Please don't merge it right now. This is to facilitate viewing the changed code. There are still some todos and tests that need to be done.

suragch commented 3 months ago

@Satsrag When do you think this will be ready to merge? I'm ok with merging even before it is ready for publishing as long as it is in a stable state. The reason I am asking is that I was thinking of upgrading to Flutter 3.22 but I wanted to wait if that will cause breaking changes that would conflict with this PR.

Satsrag commented 3 months ago

@Satsrag When do you think this will be ready to merge? I'm ok with merging even before it is ready for publishing as long as it is in a stable state. The reason I am asking is that I was thinking of upgrading to Flutter 3.22 but I wanted to wait if that will cause breaking changes that would conflict with this PR.

Almost this week. You go on to upgrade to Flutter 3.22 first. If this PR conflicts with the master branch, I will fix this PR before merging.

suragch commented 3 months ago

@Satsrag I pushed a commit on master to fix a breaking change with Flutter 3.22. Hopefully that won't making merging your changes too difficult.

Satsrag commented 3 months ago

@suragch coding is done. Now all that's left is testing. Should we add Unit Test like Flutter way or just test manually？

suragch commented 3 months ago

Unit tests are definitely better because manual testing is often incomplete and likely to miss details in the future. However, it's also a lot of work to write tests in the first place. I'll go ahead and manually test what I can now. Anytime you want to add widget tests would be great though.

Satsrag commented 3 months ago

Unit tests are definitely better because manual testing is often incomplete and likely to miss details in the future. However, it's also a lot of work to write tests in the first place. I'll go ahead and manually test what I can now. Anytime you want to add widget tests would be great though.

Agreeing with you. Now We test manually first. Please, have a look at the comments I have changed, I am not good at English. Thank you!