search

suraj0208 / WhatsappExtensions

Xposed module for WhatsApp
Apache License 2.0
100 stars 34 forks source link

Update strings.xml #5

Closed pmsobrado closed 7 years ago

pmsobrado commented 7 years ago

Just changing c for C :)

suraj0208 commented 7 years ago

Thank you but there is no need to do this. The original button is named 'Call' I kept it 'call' to tell the difference.

pmsobrado commented 7 years ago

2016-10-20 12:06 GMT+02:00 Suraj notifications@github.com:

you but there is no need to do this. The original button is named 'Call' I kept it 'call' to tell the difference.

Sorry but at least on my phone I see only yours, the WA one is outside, check the screenshots:

Anyway, maybe you could go with "Cell call" or something, I know it's silly but seeing all the words with capitals but yours annoy me a bit :S

suraj0208 commented 7 years ago

You can long press the original one to see its title ( toast appears at bottom ). It does have a title even if you dont see it. In the next release I've added the replacement option so from next version you can disable the 'call' from menu. ok ? if you dont want to wait, compile the current code and install. Select 'replace call button' from the module.

pmsobrado commented 7 years ago

I'll check next version. Did you check my second cap? You can see the menu openened and the "call" string.

On 20 Oct 2016 13:55, "Suraj" notifications@github.com wrote:

You can long press the original one to see its title ( toast appears at bottom ). It does have a title even if you dont see it. In the next release I've added the replacement option so from next version you can disable the 'call' from menu. ok ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/suraj0208/WhatsappExtensions/pull/5#issuecomment-255085217, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ4Tm7c14GNHVcTPzhDJA00PGtxDSuIoks5q11bNgaJpZM4Kb4sf .

suraj0208 commented 7 years ago

Sorry but I didnt understand what you mean by 'second cap'. also explain 'You can see the menu openened and the "call" string.'

pmsobrado commented 7 years ago

Didnt you check the attached screenshots? thats what I meant :)

On 20 Oct 2016 16:49, "Suraj" notifications@github.com wrote:

Sorry but I didnt understand what you mean by 'second cap'. also explain 'You can see the menu openened and the "call" string.'

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/suraj0208/WhatsappExtensions/pull/5#issuecomment-255128198, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ4Tm6jNRIXJ16siADMfgNrwMxNMkBb2ks5q139ygaJpZM4Kb4sf .

suraj0208 commented 7 years ago

I did not receive screenshot

pmsobrado commented 7 years ago

Im sorry, I attached them on gmail. I'll try later

On 20 Oct 2016 17:56, "Suraj" notifications@github.com wrote:

I did not receive screenshot

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/suraj0208/WhatsappExtensions/pull/5#issuecomment-255148188, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ4Tm7kRqvlV0hiRvlbMx-0zs1dx-YOQks5q148rgaJpZM4Kb4sf .

pmsobrado commented 7 years ago

Did you get the screenshots?

2016-10-20 20:54 GMT+02:00 Pablo Sobrado Gómez pmsobrado@emergya.com:

There you go:

https://drive.google.com/file/d/0B9pc9wI3CiMMR3Jzel9XMkpRM3R3e W1SazJHWGRkOGpoem5r/view?usp=sharing

https://drive.google.com/file/d/0B9pc9wI3CiMMWVBibGNwQzIwNGlEW EJXbXU0TS1RNF9zLWZV/view?usp=sharing

  • Pablo Manuel Sobrado Gómez* Projects area - Devops
    • Emergya Consultoría* Tfno: +34 954 51 75 77 Fax: +34 954 51 64 73 www.emergya.es

2016-10-20 17:58 GMT+02:00 Pablo Sobrado Gómez pmsobrado@emergya.com:

Im sorry, I attached them on gmail. I'll try later

On 20 Oct 2016 17:56, "Suraj" notifications@github.com wrote:

I did not receive screenshot

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/suraj0208/WhatsappExtensions/pull/5#issuecomment-255148188, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ4Tm7kRqvlV0hiRvlbMx-0zs1dx-YOQks5q148rgaJpZM4Kb4sf .

pmsobrado commented 7 years ago

There you go:

https://drive.google.com/file/d/0B9pc9wI3CiMMR3Jzel9XMkpRM3R3eW1SazJHWGRkOGpoem5r/view?usp=sharing

https://drive.google.com/file/d/0B9pc9wI3CiMMWVBibGNwQzIwNGlEWEJXbXU0TS1RNF9zLWZV/view?usp=sharing

2016-10-20 17:58 GMT+02:00 Pablo Sobrado Gómez pmsobrado@emergya.com:

Im sorry, I attached them on gmail. I'll try later

On 20 Oct 2016 17:56, "Suraj" notifications@github.com wrote:

I did not receive screenshot

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/suraj0208/WhatsappExtensions/pull/5#issuecomment-255148188, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ4Tm7kRqvlV0hiRvlbMx-0zs1dx-YOQks5q148rgaJpZM4Kb4sf .

suraj0208 commented 7 years ago

just wait for next version. I'll update this week.

pmsobrado commented 7 years ago

Ok thanks.

On 1 Nov 2016 7:26 a.m., "Suraj" notifications@github.com wrote:

just wait for next version. I'll update this week.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

suraj0208 commented 7 years ago

See the new version. If you are satisfied with the replace functionality close the pull request. I'm sorry it cannot be changed to 'Call' it has to be 'call'

pmsobrado commented 7 years ago

I still can see the call string without the uppercase, but with the replace call button option that doesn't happen anymore, thanks!

2016-11-01 17:13 GMT+01:00 Suraj notifications@github.com:

See the new version. If you are satisfied with the replace functionality close the pull request. I'm sorry it cannot be changed to 'call' it has to be 'Call'

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/suraj0208/WhatsappExtensions/pull/5#issuecomment-257610375, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ4Tm2dnBQ_JCTtMBdM6flj6oDG22Wxsks5q52VCgaJpZM4Kb4sf .