Hide conversation has no effect now

suraj0208 / WhatsappExtensions

Xposed module for WhatsApp

Apache License 2.0

100 stars 34 forks source link

Hide conversation has no effect now #51

Closed bilogic closed 6 years ago

bilogic commented 6 years ago

Hi,

After the recent WhatsApp update, the hide conversation functionality has no effect, i.e. it does not hide the conversation anymore. Able to fix?

Thank you.

suraj0208 commented 6 years ago

I've fixed. Not working on this module actively. I'll update once done.

bilogic commented 6 years ago

Hi,

Thanks. But I don't see any commits or updates on Xposed?

suraj0208 commented 6 years ago

I'll push the changes. Currently I'm way too busy with office work. I hardcoded somethings to get working so didnt push the code.

bilogic commented 6 years ago

Ok, understand. I will wait. Thank you.

bilogic commented 6 years ago

Hi, would you mind sharing the changes you made here? I can help clean up the hardcoded parts and make a pull request. Thank you.

suraj0208 commented 6 years ago

sorry I'll push today

bilogic commented 6 years ago

Hi,

I think there was new WhatsApp update these few days. Hide stopped working again. In fact, WhatsappExtensions seems to be causing WhatsApp to crash.

Could you have a look? Thank you.

bilogic commented 5 years ago

Hi,

I just want to highlight that the following released versions of WhatsappExtensions have issues with the latest WhatsApp 2.19.17:

6.1 - WhatsApp crashes
6.2 - Cannot install, error is "App not installed"
6.3 - Cannot install, error is "App not installed"
6.31 - WhatsApp crashes

Only the earlier unreleased WhatsappExtensions 6.13 is works. Thank you.

suraj0208 commented 5 years ago

which android version are you using?

suraj0208 commented 5 years ago

also if possible send logcat. I just tried and its working at my end

bilogic commented 5 years ago

I'm on Marshmellow. Logcat, let me try.

bilogic commented 5 years ago

Hi,

The logcat for WhatsApp 2.19.98 and WhatsAppExtensions 6.31. Thank you.

logcat_04-12-2019_21-59-10.txt

bilogic commented 5 years ago

Hi,

Looking at the logs, why does WhatsApp keep trying to create the table new_sticker_packs, which already exists? This happens only when WhatsappExtensions is in use.

bilogic commented 5 years ago

@suraj0208 are you seeing this or should I open a new ticket? Thank you.