Add project: CGPA Calculator

surajm-333 / Ace-The-FrontEnd

This repository contains frontend projects that will help you to become an ace Frontend Developer.

198 stars 173 forks source link

Add project: CGPA Calculator #714

Closed BIKRAM-SAHA closed 2 years ago

BIKRAM-SAHA commented 2 years ago

Description 📜

Add HTML, CSS, JS
is mobile responsive

Fixes #175

Type of change 📝

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Domain of Contribution 📊

[x] HTML, CSS, JS
[ ] React
[ ] Angular
[ ] Vue
[ ] Next.js
[ ] UI/UX
[ ] Other

Checklist ✅

[x] I follow Code of conduct of this project.
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added required screenshot/gif depicting the working of the project in the folder
[x] I am a GSSoC'22 contributor

Screenshots / Gif 📸

surajm-333 commented 2 years ago

@BIKRAM-SAHA if sgpa1 = 9.44 and sgpa2 = 8.78 then how is ygpa = 9.44?

BIKRAM-SAHA commented 2 years ago

@BIKRAM-SAHA if sgpa1 = 9.44 and sgpa2 = 8.78 then how is ygpa = 9.44?

@surajm-333 apologies the issue happened because I did not type cast value from input fields to float before calculating. Have corrected the comment and made necessary changes

surajm-333 commented 2 years ago

@BIKRAM-SAHA if sgpa1 = 9.44 and sgpa2 = 8.78 then how is ygpa = 9.44?

@surajm-333 apologies the issue happened because I did not type cast value from input fields to float before calculating. Have corrected the comment and made necessary changes

Upload a screenshot of calculation of all 4 ygpa and total cgpa. Also I think the formula for Total Cgpa you have mentioned is incorrect. If it is so then correct it.

BIKRAM-SAHA commented 2 years ago

@BIKRAM-SAHA if sgpa1 = 9.44 and sgpa2 = 8.78 then how is ygpa = 9.44?

@surajm-333 apologies the issue happened because I did not type cast value from input fields to float before calculating. Have corrected the comment and made necessary changes

Upload a screenshot of calculation of all 4 ygpa and total cgpa. Also I think the formula for Total Cgpa you have mentioned is incorrect. If it is so then correct it.

@surajm-333

BIKRAM-SAHA commented 2 years ago

Upload screenshot of all 4 YGPA and Total CGPA. Also correct the Total CGPA formula.

again I apologize there is a slight mistake it should be: CGPA= (YGPA1+YGPA2+1.5*YGPA3+1.5*YGPA4)/5 I will update the same in the code. If you think it should be anything else please comment I will do the necessary changes

BIKRAM-SAHA commented 2 years ago

Upload screenshot of all 4 YGPA and Total CGPA. Also correct the Total CGPA formula.

@surajm-333 Updated values:

CGPA= CGPA= (YGPA1+YGPA2+1.5YGPA3+1.5YGPA4)/5

anamansari062 commented 2 years ago

@BIKRAM-SAHA Add proper heading of pr

BIKRAM-SAHA commented 2 years ago

@BIKRAM-SAHA Add proper heading of pr

@anamansari062 done

BIKRAM-SAHA commented 2 years ago

have updated the CGPA value in the HTML too