Closed pakholeung37 closed 2 years ago
Very cool - just for visibility for others on the issue, https://github.com/suren-atoyan/monaco-react/issues/217 has a good related discussion
@suren-atoyan Is there any problem I could help with?
Why this has not been merged yet @syumai
This would be really nice to have. Any reason to not merge? This project is great BTW
@suren-atoyan are you still around?
@suren-atoyan I'm sorry to bother you, but would it be possible to merge this?
Thank you for this project!
@suren-atoyan my project is stuck as well, would be cool if this gets merged please
Hi everyone 👋
Sorry, for the late answer. This will be ready this weekend 🙂
@pakholeung37 thank you for your support 💚 There are some inconsistency issues in the PR, plus I have other changes in other places, so, most probably I'll close your PR, but your suggested API will be shipped 🚢 🙌
hey everyone 👋 @Sparkenstein @BrianMcBrayer @ShivamJoker @pakholeung37 @ColmanHumphrey
The new version is released 🎉 v1.3.0
check this
Thanks everyone for support!
The community keeps asking how to load monaco from node_modules, here's the solution. Now you can inject the monaco instance to loader by giving an option to
init
.The first
init
will call out a promise, everyinit
call behind will return that promise.you can reload also
14
suren-atoyan/monaco-react#327 suren-atoyan/monaco-react#322