Closed tarngerine closed 2 years ago
having the same issue here
Having the same issue
Please check this snippet. I removed React.StrictMode
and commented loader.init
line. Somehow it stucks after trying to be initialized a second time.
I'll examine it tomorrow.
okay, I see what's the problem, will solve this in the next version
thanks for taking a look! looking forward to the fix <3
i thought that calling .init() was required for the config to actually apply to the loader — is that correct?
it's not required. Editor
component will call loader.init
the first time it renders
@tarngerine @imguolao @miaawong could you please check the latest version?
@tarngerine @imguolao @miaawong could you please check the latest version?
Yes, it is working. Great! (:
Amazing, it's working! thank you
Describe the bug Following the instructions on the README for loading monaco-editor as an npm module (not using CDN) in Vite, it does not work. https://github.com/suren-atoyan/monaco-react#use-monaco-editor-as-an-npm-package
It used to work! I am not sure when this stopped working - sometime in the last few weeks. I was using 4.4.1 locally before, and had recently updated to React 18. I created a fresh sandbox repro.
To Reproduce
loader.config({monaco})
) it works fineExpected behavior It should load and show "HELLO" in the monaco editor
Screenshots Broken:
Comment out 9-40 (loader code) works fine: