search

suren-atoyan / monaco-loader

The utility to easy setup monaco-editor into your browser
MIT License
177 stars 37 forks source link

Does this package work with https://github.com/microsoft/monaco-editor/tree/main/webpack-plugin? #28

Closed wegry closed 1 year ago

wegry commented 1 year ago

It seems like the languages option of monaco-editor-webpack-plugin@7.0.1 doesn't have languages respected. If just typescript and javascript are set, all languages are being output with ~in~ version @monaco-editor/react@4.4.6.

import * as monaco from "monaco-editor";
import { loader } from "@monaco-editor/react";

loader.config({ monaco });

// ...
suren-atoyan commented 1 year ago

@wegry what exactly does all languages are being output with in ... mean?

wegry commented 1 year ago

@suren-atoyan php, mysql, yaml, etc. are all included.

wegry commented 1 year ago

Using 

- import * as Monaco from 'monaco-editor';
+ import * as monaco from 'monaco-editor/esm/vs/editor/editor.api';

for importing Monaco seems work when the only languages in my output I'd like to include are TS and JS.