search

suren-atoyan / monaco-react

Monaco Editor for React - use the monaco-editor in any React application without needing to use webpack (or rollup/parcel/etc) configuration files / plugins
https://monaco-react.surenatoyan.com/
MIT License
3.81k stars 268 forks source link

Incompatible with the latest React version v18 #359

Closed cordosvictor closed 2 years ago

cordosvictor commented 2 years ago

The library seems to be incompatible with the latest React version v18. I'm trying to install the library and I get the following error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: flowbite@0.1.0
npm ERR! Found: react@18.0.0
npm ERR! node_modules/react
npm ERR!   react@"^18.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0 || ^17.0.0" from @monaco-editor/react@4.4.1
npm ERR! node_modules/@monaco-editor/react
npm ERR!   @monaco-editor/react@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
suren-atoyan commented 2 years ago

@cordosvictor could you please check the latest version - v4.4.2?

andysm1th commented 2 years ago

I don't have this issue with v4.4.1 running React 18, but I have noticed there was the v4.4.2 release on NPM with no corresponding one here. Where can we see the changes?

suren-atoyan commented 2 years ago

@andysmithnf release and changelog