search

sureshchahal / angular2-adal

Angular 2 wrapper for adal.js
MIT License
41 stars 50 forks source link

Don´t log errors to console #53

Closed ericivarsson closed 7 years ago

ericivarsson commented 7 years ago

I might be wrong but I think it would be better to just return the error and leave all error handling to the client/initiator.

I have a problem right now where I´m calling the User/Photos endpoint of Microsoft Graph API. If a user doesn´t have a photo, the API return an 404 by design (https://developer.microsoft.com/en-us/graph/docs/api-reference/beta/api/profilephoto_get). In this case I don´t want these 404´s logged to the console.

What do you think?

sureshchahal commented 7 years ago

I agree. Will remove this sometime next week

On Tue, Jun 27, 2017 at 4:52 PM, Eric Ivarsson notifications@github.com wrote:

I might be wrong but I think it would be better to just return the error and leave all error handling to the client/initiator.

I have a problem right now where I´m calling the User/Photos endpoint of Microsoft Graph API. If a user doesn´t have a photo, the API return an 404 by design (https://developer.microsoft.com/en-us/graph/docs/api- reference/beta/api/profilephoto_get). In this case I don´t want these 404´s logged to the console.

What do you think?

You can view, comment on, or merge this pull request online at:

https://github.com/sureshchahal/angular2-adal/pull/53 Commit Summary

  • Don´t log errors to console

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sureshchahal/angular2-adal/pull/53, or mute the thread https://github.com/notifications/unsubscribe-auth/ARLaHyOYASVMnN4Io6yY8odQ7J9-PI73ks5sIXmFgaJpZM4OHPT2 .