search

sureshchahal / angular2-adal

Angular 2 wrapper for adal.js
MIT License
41 stars 50 forks source link

Typescript 2.4 breaking change #55

Open claudiuconstantin opened 7 years ago

claudiuconstantin commented 7 years ago

Withng2_adal 1.0.1 I'm getting a:

ERROR in [at-loader] ./node_modules/ng2-adal/node_modules/rxjs/Subject.d.ts:16:22
    TS2415: Class 'Subject<T>' incorrectly extends base class 'Observable<T>'.
  Types of property 'lift' are incompatible.
    Type '<R>(operator: Operator<T, R>) => Observable<T>' is not assignable to type '<R>(operator: Operator<T, R>) => Observable<R>'.
      Type 'Observable<T>' is not assignable to type 'Observable<R>'.
        Type 'T' is not assignable to type 'R'.

This is probably related to some breaking change in the new Typescript 2.4.1.

aciccarello commented 7 years ago

TypeScript 2.4 does have tighter generic checking. In this case it looks to be an issue with the rxjs library, not ng2-adal. I think this can be mitigated if you specify a higher version of rxjs in your own package.json file.

claudiuconstantin commented 7 years ago

The issue was fixed, you can close this one

sureshchahal commented 7 years ago

@claudiuconstantin what was fix???

fume commented 7 years ago

Upgrading rxjs I guess...