search

sureshchahal / angular2-adal

Angular 2 wrapper for adal.js
MIT License
41 stars 50 forks source link

Incorrect version 1.0.2 #66

Open BennyM opened 7 years ago

BennyM commented 7 years ago

Today I was greeted with breaking builds because version 2.0 has been accidentally released as 1.0.2 and we allowed minor upgrades to take place. Perhaps release 1.0.3 which corrects this issue or unlist the package all together as it has been a mistake: https://docs.npmjs.com/cli/unpublish

Note to people using this library: either only allow the latest version which worked 1.0.1 or upgrade the code base to 2.0.0.

I'm posting this because other people will also encounter this.

It would also be helpful if release history and version information is available here on the repo.

sureshchahal commented 7 years ago

sorry for confusion. I cannot un publish as npm allow only 24 hours. I have submitted an request with npm to un publish it.

Davilink commented 7 years ago

Any news ?

sureshchahal commented 7 years ago

NPM have refused to unpublish this version . I will try to publish 1.0.3 sometime next week

claudiuconstantin commented 7 years ago

As per npm documentation:

It is generally considered bad behavior to remove versions of a library that others are depending on! Consider using the deprecate command instead, if your intent is to encourage users to upgrade

So you can just do a npm deprecate ng2-adal@"< 1.0.3" "upgrade to v1.0.3 is strongly recommended" after you publish the new 1.0.3

nitinmidha commented 7 years ago

I have published version 1.0.3 which is the current build from Angular2 branch. I have deprecated any versions below 1.0.3.

sureshchahal commented 7 years ago

@nitinmidha thanks. I will keep this open for few days so that people will have visibility in issue and what to do