search

sureshchahal / angular2-adal

Angular 2 wrapper for adal.js
MIT License
41 stars 50 forks source link

Example using the 2.0.0 version #67

Open claudiuconstantin opened 6 years ago

claudiuconstantin commented 6 years ago

Can you provide an example using the new angular 4 version of the package? Seems that some breaking changes were introduced lately

sureshchahal commented 6 years ago

It is same but used angular 4

On Mon, Sep 18, 2017 at 7:31 AM Claudiu Constantin notifications@github.com wrote:

Can you provide an example using the new angular 4 version of the package? Seems that some breaking changes were introduced lately

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sureshchahal/angular2-adal/issues/67, or mute the thread https://github.com/notifications/unsubscribe-auth/ARLaH3H93yLYo-mTuN48ZgHPbBK7EAdOks5sjn7KgaJpZM4PbAHK .

claudiuconstantin commented 6 years ago

Well, I use ng2-adal: ^2.0.0, importing import { AdalService } from "ng2-adal/core" and I'm getting this:

Module not found: Error: Can't resolve 'ng2-adal/core'

rjwijnen commented 6 years ago

Use ng2-adal/dist/core instead

claudiuconstantin commented 6 years ago

Ok, that worked. This should be specified in the package description, a lot of people will have this issue after upgrade. You can close this one.

skorunka commented 6 years ago

I had the same problem as @claudiuconstantin . I appreciate your hard work guys, but please, when you release a new version, with a breaking changes, please make sure you outline the breaking changes somewhere. Thank you.

FabianGosebrink commented 6 years ago

Had the same problems. Missed the changelog and the release tag here in github. Nice work but remember that you have to reflect the changes for you users. Thanks :) Keep it up.

jderus commented 6 years ago

Had the same problem. Would be nice to see the example updated, and have it also include proper usage of AuthHttp.

hitmanpc commented 6 years ago

Yeah it took me 2 days to find this ... thanks for updating this issue.

claudiuconstantin commented 6 years ago

I created a pull request with the improved Readme file, check it out

ranveeraggarwal commented 6 years ago

I have updated the example to use the latest version of this package and Angular 4.