need some indicator on "My Dashboard" for which reviews there are comments on and which ones I've commented on.

sureshvv / reviewboard

Automatically exported from code.google.com/p/reviewboard

0 stars 0 forks source link

need some indicator on "My Dashboard" for which reviews there are comments on and which ones I've commented on. #106

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What's the URL of the page containing the problem?
    http://reviewboard.eng.vmware.com/dashboard/

What steps will reproduce the problem?
1. Choose a review to review.
2. Comment, save, publish
3. No visual indicator shows up on review entry in
   dashboard to show what review you just commented on.

What is the expected output? What do you see instead?
Expected:
        Side icon to indicate that the particular review
        has someone's comments affixed.

Reality:
        No such visual indicator.

What operating system are you using? What browser?
  This is on Windows XP, FireFox 2.0.4

Please provide any additional information below.

Original issue reported on code.google.com by br...@vmware.com on 11 Jun 2007 at 9:10

GoogleCodeExporter commented 9 years ago

Original comment by trowb...@gmail.com on 12 Jun 2007 at 7:38

Added labels: Component-Dashboard, Type-Enhancement
Removed labels: Type-Defect

GoogleCodeExporter commented 9 years ago

We now have part of this. You can see if there are new comments. I'm not sure 
if an
indicator showing that you have commented on it is a good thing to add just 
because
you can usually keep track of this yourself and it might clutter things up, but 
if
you have any ideas on how to integrate that cleanly, I'm all ears.

Original comment by chip...@gmail.com on 3 Sep 2007 at 2:25

Changed title: need some indicator on "My Dashboard" for which reviews there are comments on and which ones I've commented on.

GoogleCodeExporter commented 9 years ago

Original comment by chip...@gmail.com on 1 Oct 2007 at 8:39

Added labels: Priority-Low
Removed labels: Priority-Medium

GoogleCodeExporter commented 9 years ago

For what it's worth, we've been using Reviewboard a bit in the tools team where 
I
work, and I've been having a hard time keeping track of which reviews I've 
already
commented on sometimes (we have a pretty high queue of reviews). So, I think 
that
some kind of icon next to the reviews that indicates whether or not you've 
already
commented on it would be helpful in some cases.

Original comment by d.anthon...@gmail.com on 4 Oct 2007 at 8:26

GoogleCodeExporter commented 9 years ago

This is easier now that we have datagrids.

Original comment by chip...@gmail.com on 23 Dec 2007 at 7:10

Added labels: Milestone-Release1.0, Priority-High
Removed labels: Priority-Low

GoogleCodeExporter commented 9 years ago

I took a crack at an implementation, and have submitted for review:

http://reviews.review-board.org/r/285/

Please take a look and see if you like it.

Original comment by bret.mcm...@gmail.com on 28 Feb 2008 at 6:34

GoogleCodeExporter commented 9 years ago

Fixed as r1315.  It'll be a little ugly until Christian makes some new icons 
(bug 474)

Original comment by trowb...@gmail.com on 26 Apr 2008 at 4:12

Changed state: Fixed