sureshvv / reviewboard

Automatically exported from code.google.com/p/reviewboard
0 stars 0 forks source link

Whose 'court' the review in currently in? #396

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
It'd be nice to see in the dashboard view whose 'court' the review was
currently in: if the last update was a review request, it's *review
pending*; if it's received feedback without a Ship It, it's *update
pending*; if it's received feedback with a Ship It, it's *approved by N
reviewers*.

Original issue reported on code.google.com by sudarkoff on 7 Feb 2008 at 6:45

GoogleCodeExporter commented 9 years ago

Original comment by trowb...@gmail.com on 9 Feb 2008 at 9:53

GoogleCodeExporter commented 9 years ago
Sounds like a Status column would work.

Original comment by chip...@gmail.com on 13 Feb 2008 at 9:18

GoogleCodeExporter commented 9 years ago
That would work. Please also expose this bit of information through the API as 
well.

Original comment by sudarkoff on 13 Feb 2008 at 8:50

GoogleCodeExporter commented 9 years ago
We're trying to keep from adding too many more features for 1.0. Unless someone 
wants
to write a patch I'm moving this to 2.0.

Original comment by chip...@gmail.com on 25 Feb 2008 at 3:22

GoogleCodeExporter commented 9 years ago
I agree completely.  It also makes sense that RB would be able to display who 
has
reviewed since the patch was last updated and make it possible to determine 
when a
review is required for approval by a particular individual or group versus a 
review
is available to a particular group or individual (not required for approval).

Original comment by kevin.be...@beatport.com on 20 Aug 2008 at 7:25

GoogleCodeExporter commented 9 years ago
Just throwing in my 2 cents for when someone gets around to implementing this, 
as this is one of the 
main annoyances I have with reviewboard.  I spend a lot of time re-opening 
reviews to see what's 
happened.  I think what people want is a "My next requested action" column.  
Calling it status would 
still work, but tailored to the next action would be best.

The above comments address the issue for outgoing reviews.  For incoming 
reviews, however, it'd be 
nice to see how the logged-in reviewer last addressed the review.

Incoming statuses:
"Review needed"
"Draft review saved"
"Review submitted, awaiting new diff"
"Review submitted, marked as Ship It"

Outgoing statuses:
"Awaiting reviews"
"Modifications requested, approved by N of N reviewers"
"Approved by N of N reviewers"
"Ready to submit"

Original comment by jeffl...@gmail.com on 4 Feb 2009 at 11:27

GoogleCodeExporter commented 9 years ago
Thanks for the 2 cents Jeff :)

I just wanted to address one thing real quick. You mentioned that you spend a 
lot of
time looking at review requests to see if anything changed. Are you using the 
"New
Updates" column to at least only open review requests that have had changes 
made?

Original comment by chip...@gmail.com on 4 Feb 2009 at 11:29

GoogleCodeExporter commented 9 years ago
Yes, I am.  It helps, but comes short.

For example, look at this situation.  I see a new update to a review, and it's 
a huge rewrite that's going to take some 
serious time to look over.  I can't get to it right now, so I put it aside for 
later.  (Maybe a "mark as unread" 
ability is needed to restore the new updates icon?)

Now, do this once or twice and I can't trust the new updates icon anymore.  I 
don't know the real status of anything.  
So I have to go through the entire list of reviews, which inevitably entails 
re-reading a lot of comments just to make 
sure I'm not inadvertently being lazy.

Original comment by jeffl...@gmail.com on 5 Feb 2009 at 12:22

GoogleCodeExporter commented 9 years ago
Yeah. I definitely agree with you. I just wanted to make sure you weren't at 
least
randomly reloading pages without knowing if anything changed or not :)

Original comment by chip...@gmail.com on 5 Feb 2009 at 12:27

GoogleCodeExporter commented 9 years ago
This actually feels very closely related to Issue 739. Perhaps this will become 
less urgent once you can scan the "Last Updated By" column to see anything that 
doesn't have your username?

Original comment by yuzi...@gmail.com on 9 Jan 2011 at 9:18

GoogleCodeExporter commented 9 years ago
Issue 1924 has been merged into this issue.

Original comment by trowb...@gmail.com on 10 Jan 2011 at 5:34

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Issue 2530 has been merged into this issue.

Original comment by trowb...@gmail.com on 18 Mar 2012 at 3:29

GoogleCodeExporter commented 9 years ago

Original comment by trowb...@gmail.com on 20 Jan 2014 at 8:43