Closed GoogleCodeExporter closed 9 years ago
Original comment by trowb...@gmail.com
on 7 Jun 2008 at 9:42
Not a bad idea, except it shouldn't be limited to CVS, and for many repository
types
the native diffs don't work anyway, requiring the use of post-review. Still,
might be
useful in some cases.
Original comment by chip...@gmail.com
on 2 Aug 2008 at 8:53
Original comment by chip...@gmail.com
on 25 Aug 2008 at 10:55
I love this idea....
Paste a Unidiff from TSvn, etc.. right into the review request box.
Have some regex rules for stream editing the diff to make it fit. In our case
(subversion with Tortoise), the diffs from Tortoise are nearly correct, but
require
a little editing of the paths at the top.
ex:
change
c:\project\2009
to
\2009
This would save a few steps. And with some simple regex/stream editing, we
should
be able to cook up rules to fix most diffs, on-the-fly.
Also, in our case, post-review isn't a good solution. We typically have
several
files in various directories that need to go into the same review, yet there
are
files in those directories that have changed, but are NOT part of the review.
So we
need to make a UniDiff that spans several directories, with just the files that
we
want. Tortoise can make these Diffs easily, and ReviewBoard handles them
nicely
(multiple files from different directories, in a single diff).
Original comment by thornsof...@gmail.com
on 17 Apr 2009 at 2:06
In a similar vein we are using RB to discuss and agree solutions before
implementation as well as its intended purpose. This means that the whole
discussion
about a change is in one place. At the moment this requires us to initially
load an
empty dummy.diff file which is replaced with a diff containing the real code
when it
is produced.
It would be nice not to have to load the dummy file as this is confusing for
new
users.
Original comment by charlesm...@gmail.com
on 24 Nov 2009 at 12:32
I'm going to close this out since I don't think there's any chance that one of
us will implement it. If someone is willing to take the time to implement this,
we'd consider accepting it.
Original comment by trowb...@gmail.com
on 22 Jan 2014 at 11:40
Original issue reported on code.google.com by
ball...@gmail.com
on 6 Jun 2008 at 2:29