sureshvv / reviewboard

Automatically exported from code.google.com/p/reviewboard
0 stars 0 forks source link

Add an option to paste in a diff instead of uploading for cvs users #507

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What's the URL of the page containing the problem?
server:8000/r/2/

What steps will reproduce the problem?
1. create a new review on a cvs system
2.
3.

What is the expected output? What do you see instead?
I'd like it if I had the option to upload a diff file or just copy and
paste one into a text field. I am working in one city where by browser is
running, but the code to diff is in another city.  Getting the diff onto my
browser computer is difficult.

Or if you wanted to get fancy, you could have it accept emails of diffs cvs
 diff -wu blah | mailx -s 'review' reviewboard@example.com.  Then it would
become an unsubmitted review request in my account.

What operating system are you using? What browser?
firefox2 on vista. putty & ssh to a fedora 6 system for coding.

Please provide any additional information below.
great tool. thanks!

Original issue reported on code.google.com by ball...@gmail.com on 6 Jun 2008 at 2:29

GoogleCodeExporter commented 9 years ago

Original comment by trowb...@gmail.com on 7 Jun 2008 at 9:42

GoogleCodeExporter commented 9 years ago
Not a bad idea, except it shouldn't be limited to CVS, and for many repository 
types
the native diffs don't work anyway, requiring the use of post-review. Still, 
might be
useful in some cases.

Original comment by chip...@gmail.com on 2 Aug 2008 at 8:53

GoogleCodeExporter commented 9 years ago

Original comment by chip...@gmail.com on 25 Aug 2008 at 10:55

GoogleCodeExporter commented 9 years ago
I love this idea....  
Paste a Unidiff from TSvn, etc.. right into the review request box. 
Have some regex rules for stream editing the diff to make it fit.  In our case 
(subversion with Tortoise), the diffs from Tortoise are nearly correct, but 
require 
a little editing of the paths at the top.  
ex: 
change
c:\project\2009
to
\2009

This would save a few steps.  And with some simple regex/stream editing, we 
should 
be able to cook up rules to fix most diffs, on-the-fly.

Also, in our case, post-review isn't a good solution.  We typically have 
several 
files in various directories that need to go into the same review, yet there 
are 
files in those directories that have changed, but are NOT part of the review.  
So we 
need to make a UniDiff that spans several directories, with just the files that 
we 
want.  Tortoise can make these Diffs easily, and ReviewBoard handles them 
nicely 
(multiple files from different directories, in a single diff).

Original comment by thornsof...@gmail.com on 17 Apr 2009 at 2:06

GoogleCodeExporter commented 9 years ago
In a similar vein we are using RB to discuss and agree solutions before 
implementation as well as its intended purpose. This means that the whole 
discussion 
about a change is in one place.  At the moment this requires us to initially 
load an 
empty dummy.diff file which is replaced with a diff containing the real code 
when it 
is produced. 

It would be nice not to have to load the dummy file as this is confusing for 
new 
users.

Original comment by charlesm...@gmail.com on 24 Nov 2009 at 12:32

GoogleCodeExporter commented 9 years ago
I'm going to close this out since I don't think there's any chance that one of 
us will implement it. If someone is willing to take the time to implement this, 
we'd consider accepting it.

Original comment by trowb...@gmail.com on 22 Jan 2014 at 11:40