Closed GoogleCodeExporter closed 9 years ago
Try to use the post-review tool to generate/upload the diff and see if that
fixes
your problem.
Original comment by chip...@gmail.com
on 20 Jun 2008 at 9:22
I will try that.
But that would be merely a workaround and not a fix for this issue.
I hope the core developers of review-board can have a look at it and at least
avoid
that exception as seen above.
Thanks.
Original comment by mkoeb...@gmail.com
on 23 Jun 2008 at 12:14
We can't do much, though. SVN diffs that do copies or renames provide broken
information and we can't know it's broken. The best we can do is display an
inline
error for that file, or just drop it. Neither are great solutions. This is why
post-review must be used for these cases, as we can generate our own fixed diff.
Original comment by chip...@gmail.com
on 4 Aug 2008 at 8:59
With SVN, it's very hard (if not impossible) to tell the difference between a
file
that has a broken copy and a file which is uploaded from the web UI with the
wrong
base diff path. We may want to come up with a generic error to show in this
case.
Either way, we ought to check the diff for problems when it gets uploaded
instead of
when it's viewed.
Original comment by trowb...@gmail.com
on 6 Oct 2008 at 8:03
Speaking of which, I'm going to merge this into bug 583.
Original comment by trowb...@gmail.com
on 24 Mar 2009 at 5:33
does this mean that "svn copy" will not be fixed?
bug 583 talks about validation, will reviewboard then simply reject diffs
containing
files created by a svn copy?
Original comment by mkoeb...@gmail.com
on 25 Mar 2009 at 1:28
There's no way for us to "fix" this. "svn diff" is what's broken, we can merely
work
around it.
Original comment by trowb...@gmail.com
on 25 Mar 2009 at 8:54
Original issue reported on code.google.com by
mkoeb...@gmail.com
on 20 Jun 2008 at 2:59